Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register required types for upgrade E2E tests #3132

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Feb 9, 2023

Description

closes: #3131

Workflow: https://github.com/cosmos/ibc-go/actions/runs/4134965361

Commit Message / Changelog Entry

N/A

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Merging #3132 (6ed71d8) into main (65f7038) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3132   +/-   ##
=======================================
  Coverage   78.53%   78.54%           
=======================================
  Files         179      179           
  Lines       12436    12440    +4     
=======================================
+ Hits         9767     9771    +4     
  Misses       2243     2243           
  Partials      426      426           
Impacted Files Coverage Δ
modules/apps/29-fee/keeper/grpc_query.go 75.93% <100.00%> (+0.39%) ⬆️
modules/core/keeper/msg_server.go 55.17% <100.00%> (+0.09%) ⬆️

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and we can follow up with #3136 🚀

@chatton chatton marked this pull request as ready for review February 13, 2023 11:33
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@chatton chatton enabled auto-merge (squash) February 14, 2023 10:26
@chatton chatton merged commit 59ef5bc into main Feb 14, 2023
@chatton chatton deleted the cian/issue#3131-e2e-upgrade-tests-are-failing-after-broadcast-mode-changes branch February 14, 2023 10:32
stackman27 pushed a commit to stackman27/ibc-go that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E upgrade tests are failing
4 participants