Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check x/bank send enabled before escrowing fees #2942

Merged
merged 7 commits into from
Dec 17, 2022

Conversation

crodriguezvega
Copy link
Contributor

@crodriguezvega crodriguezvega commented Dec 15, 2022

Description

closes: #XXXX

Commit Message / Changelog Entry

fix(statemachine)!: check x/bank send enabled before escrowing fees

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@crodriguezvega crodriguezvega changed the title fix: check x/bank send enabled before escrowing fees fix: check x/bank send enabled before escrowing fees Dec 15, 2022
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Super clean PR. Left one nit but feel free to ignore.
Should the commit message include fix(statemachine)!: check x/bank send enabled before escrowing fees?

modules/apps/29-fee/keeper/msg_server.go Outdated Show resolved Hide resolved
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Agree with all of @damiannolan's suggestions!

@codecov-commenter
Copy link

Codecov Report

Merging #2942 (0fe6723) into main (ca35138) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2942      +/-   ##
==========================================
+ Coverage   78.55%   78.56%   +0.01%     
==========================================
  Files         178      178              
  Lines       12271    12277       +6     
==========================================
+ Hits         9640     9646       +6     
  Misses       2206     2206              
  Partials      425      425              
Impacted Files Coverage Δ
modules/apps/29-fee/keeper/msg_server.go 97.14% <100.00%> (+0.17%) ⬆️

ulbqb pushed a commit to ulbqb/ibc-go that referenced this pull request Jul 27, 2023
ulbqb pushed a commit to ulbqb/ibc-go that referenced this pull request Jul 31, 2023
ulbqb pushed a commit to ulbqb/ibc-go that referenced this pull request Jul 31, 2023
@ulbqb ulbqb mentioned this pull request Jul 31, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants