Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed icatypes.PortPrefix to icatypes.ControllerPortPrefix #2450

Merged

Conversation

alizahidraja
Copy link
Contributor

@alizahidraja alizahidraja commented Sep 30, 2022

Description

Renamed icatypes.PortPrefix to icatypes.ControllerPortPrefix & icatypes.PortID to icatypes.HostPortID
closes: #2433


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests (already written)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/) (not applicable)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Merging #2450 (b9648ba) into main (edc4fd0) will not change coverage.
The diff coverage is 85.71%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2450   +/-   ##
=======================================
  Coverage   78.64%   78.64%           
=======================================
  Files         178      178           
  Lines       12365    12365           
=======================================
  Hits         9725     9725           
  Misses       2208     2208           
  Partials      432      432           
Impacted Files Coverage Δ
...ps/27-interchain-accounts/genesis/types/genesis.go 0.00% <0.00%> (ø)
...ps/27-interchain-accounts/host/client/cli/query.go 0.00% <0.00%> (ø)
modules/apps/27-interchain-accounts/types/keys.go 100.00% <ø> (ø)
modules/apps/27-interchain-accounts/module.go 54.00% <50.00%> (ø)
...7-interchain-accounts/controller/keeper/account.go 85.00% <100.00%> (ø)
...interchain-accounts/controller/keeper/handshake.go 89.85% <100.00%> (ø)
...nterchain-accounts/controller/keeper/migrations.go 82.35% <100.00%> (ø)
...apps/27-interchain-accounts/host/keeper/genesis.go 89.47% <100.00%> (ø)
...ps/27-interchain-accounts/host/keeper/handshake.go 89.55% <100.00%> (ø)
.../apps/27-interchain-accounts/simulation/genesis.go 95.45% <100.00%> (ø)
... and 1 more

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alizahidraja!

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ay! Thanks @alizahidraja

@crodriguezvega crodriguezvega merged commit 2056c2d into cosmos:main Oct 4, 2022
mergify bot pushed a commit that referenced this pull request Oct 4, 2022
* renamed icatypes.PortPrefix to icatypes.ControllerPortPrefix & icatypes.PortID to icatypes.HostPortID

* updated changelog.md

* updated changelog.md

(cherry picked from commit 2056c2d)
colin-axner pushed a commit that referenced this pull request Oct 4, 2022
…2459)

* renamed icatypes.PortPrefix to icatypes.ControllerPortPrefix & icatypes.PortID to icatypes.HostPortID

* updated changelog.md

* updated changelog.md

(cherry picked from commit 2056c2d)

Co-authored-by: Ali Zahid Raja <alizahidrajaa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename icatypes.PortPrefix to icatypes.ControllerPortPrefix
4 participants