change DefaultParams on the host to allow all messages ("*") #2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interchain Accounts are used by controller chains to execute transactions on the host chain. My suggestion is just as normal wallets are allowed to submit any transaction, by default, the host should allow all types of messages to be submitted using the ICAs. Allowing all messages by default makes more sense regarding the purpose of Interchain Accounts. Otherwise, it looks like this parameter should be configured to enable Interchain Accounts.
georgelombardi97
requested review from
seantking,
colin-axner,
AdityaSripal and
damiannolan
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2290 +/- ##
==========================================
- Coverage 79.52% 79.50% -0.02%
==========================================
Files 175 175
Lines 12069 12069
==========================================
- Hits 9598 9596 -2
- Misses 2047 2048 +1
- Partials 424 425 +1
|
correct formatting (gofumpt)
colin-axner
reviewed
Sep 20, 2022
colin-axner
reviewed
Sep 20, 2022
There was a problem hiding this comment.
I'm in favor of the changes, thanks for the contribution @georgelombardi97! Could you add a changelog entry?
georgelombardi97
requested review from
crodriguezvega,
charleenfei and
chatton
as code owners
|
colin-axner
approved these changes
Sep 21, 2022
chatton
approved these changes
Sep 21, 2022
mergify bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
* change DefaultParams on the host to allow all messages ("*")
Interchain Accounts are used by controller chains to execute transactions on the host chain. My suggestion is just as normal wallets are allowed to submit any transaction, by default, the host should allow all types of messages to be submitted using the ICAs.
Allowing all messages by default makes more sense regarding the purpose of Interchain Accounts.
Otherwise, it looks like this parameter should be configured to enable Interchain Accounts.
* correct formatting (gofumpt)
correct formatting (gofumpt)
* hold wildcard string in a constant
* add changelog
Co-authored-by: george <>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
(cherry picked from commit 17099fe)
crodriguezvega
added a commit
that referenced
this pull request
Sep 21, 2022
9 tasks
crodriguezvega
added a commit
that referenced
this pull request
Sep 23, 2022
* update default value allow messages after #2290 * Update parameters.md
9 tasks
damiannolan
added a commit
that referenced
this pull request
Sep 26, 2022
…2356) * change DefaultParams on the host to allow all messages ("*") Interchain Accounts are used by controller chains to execute transactions on the host chain. My suggestion is just as normal wallets are allowed to submit any transaction, by default, the host should allow all types of messages to be submitted using the ICAs. Allowing all messages by default makes more sense regarding the purpose of Interchain Accounts. Otherwise, it looks like this parameter should be configured to enable Interchain Accounts. * correct formatting (gofumpt) correct formatting (gofumpt) * hold wildcard string in a constant * add changelog Co-authored-by: george <> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> (cherry picked from commit 17099fe) Co-authored-by: georgelombardi97 <106404363+georgelombardi97@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: Damian Nolan <damiannolan@gmail.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Interchain Accounts are used by controller chains to execute transactions on the host chain. My suggestion is just as normal wallets are allowed to submit any transaction, by default, the host should allow all types of messages to be submitted using the ICAs.
Allowing all messages by default makes more sense regarding the purpose of Interchain Accounts. Otherwise, it looks like this parameter should be configured to enable Interchain Accounts.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes