-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: assert previous connection id to be empty (backport #1797) #1828
Merged
crodriguezvega
merged 3 commits into
release/v4.0.x
from
mergify/bp/release/v4.0.x/pr-1797
Jul 29, 2022
Merged
fix: assert previous connection id to be empty (backport #1797) #1828
crodriguezvega
merged 3 commits into
release/v4.0.x
from
mergify/bp/release/v4.0.x/pr-1797
Jul 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove previous connection id from NewMsgConnectionOpenTry, assert previous connection id to be empty * add changelog entry * update test * add migration docs Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 0be6c42) # Conflicts: # CHANGELOG.md
mergify
bot
requested review from
colin-axner,
fedekunze,
AdityaSripal,
crodriguezvega,
seantking and
charleenfei
as code owners
July 28, 2022 22:33
damiannolan
approved these changes
Jul 29, 2022
crodriguezvega
approved these changes
Jul 29, 2022
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 27, 2023
…cosmos#1828) * fix: assert previous connection id to be empty (cosmos#1797) * remove previous connection id from NewMsgConnectionOpenTry, assert previous connection id to be empty * add changelog entry * update test * add migration docs Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 0be6c42) # Conflicts: # CHANGELOG.md * fix conflicts Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 31, 2023
…cosmos#1828) * fix: assert previous connection id to be empty (cosmos#1797) * remove previous connection id from NewMsgConnectionOpenTry, assert previous connection id to be empty * add changelog entry * update test * add migration docs Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 0be6c42) # Conflicts: # CHANGELOG.md * fix conflicts Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 31, 2023
…cosmos#1828) * fix: assert previous connection id to be empty (cosmos#1797) * remove previous connection id from NewMsgConnectionOpenTry, assert previous connection id to be empty * add changelog entry * update test * add migration docs Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 0be6c42) # Conflicts: # CHANGELOG.md * fix conflicts Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1797 done by Mergify.
Cherry-pick of 0be6c42 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com