Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: migration docs v4 to v5 #1826

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
9705619
wip: migration docs v4 to v5
crodriguezvega Jul 28, 2022
3b1aa34
Merge branch 'main' into carlos/#1781-create-docs-for-migration-from-…
crodriguezvega Jul 28, 2022
b979950
Merge branch 'main' into carlos/#1781-create-docs-for-migration-from-…
crodriguezvega Aug 22, 2022
db26016
adding some code diffs
crodriguezvega Aug 22, 2022
bbc889c
adding more code snippets and diffs
crodriguezvega Aug 22, 2022
a195092
add link to docs
crodriguezvega Aug 22, 2022
7e0a5e8
fix alignment
crodriguezvega Aug 22, 2022
196f0c4
fix alignment
crodriguezvega Aug 22, 2022
211e8f6
fix alignment
crodriguezvega Aug 22, 2022
4603247
fix typo
crodriguezvega Aug 22, 2022
99f7c50
Merge branch 'main' into carlos/#1781-create-docs-for-migration-from-…
crodriguezvega Aug 22, 2022
0278c6c
code improvement
crodriguezvega Aug 22, 2022
bd5c1ad
Merge branch 'carlos/#1781-create-docs-for-migration-from-v4-to-v5' o…
crodriguezvega Aug 22, 2022
4b43311
Merge branch 'main' into carlos/#1781-create-docs-for-migration-from-…
crodriguezvega Aug 23, 2022
5e5f976
add links to sections in the document
crodriguezvega Aug 25, 2022
253485a
Merge branch 'carlos/#1781-create-docs-for-migration-from-v4-to-v5' o…
crodriguezvega Aug 25, 2022
8c72c04
Merge branch 'main' into carlos/#1781-create-docs-for-migration-from-…
colin-axner Aug 31, 2022
8ba5a2d
Merge branch 'main' into carlos/#1781-create-docs-for-migration-from-…
crodriguezvega Sep 5, 2022
dbb548a
Merge branch 'main' into carlos/#1781-create-docs-for-migration-from-…
colin-axner Sep 6, 2022
179f39e
add migration docs for #2058
crodriguezvega Sep 7, 2022
48a8112
added link to PR that renamed the ante decorator
crodriguezvega Sep 8, 2022
f4feb44
Merge branch 'main' into carlos/#1781-create-docs-for-migration-from-…
crodriguezvega Sep 8, 2022
3fff2f5
Merge branch 'main' into carlos/#1781-create-docs-for-migration-from-…
crodriguezvega Sep 8, 2022
7783fac
changes for #2083
crodriguezvega Sep 12, 2022
541a46d
docs: updating migration docs with additional ics27 host parameter (#…
damiannolan Sep 20, 2022
eab709b
Merge branch 'main' into carlos/#1781-create-docs-for-migration-from-…
colin-axner Sep 20, 2022
832d01c
Merge branch 'main' into carlos/#1781-create-docs-for-migration-from-…
colin-axner Sep 21, 2022
3dc8a70
Merge branch 'main' into carlos/#1781-create-docs-for-migration-from-…
crodriguezvega Sep 26, 2022
d024d4f
Merge branch 'main' into carlos/#1781-create-docs-for-migration-from-…
crodriguezvega Sep 26, 2022
013b44c
Merge branch 'main' into carlos/#1781-create-docs-for-migration-from-…
crodriguezvega Sep 26, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/apps/interchain-accounts/auth-modules.md
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ Auth modules are expected to know how to decode the acknowledgement.

If the controller chain is connected to a host chain using the host module on ibc-go, it may interpret the acknowledgement bytes as follows:

Begin by unmarshaling the acknowledgement into sdk.TxMsgData:
Begin by unmarshaling the acknowledgement into `sdk.TxMsgData`:
```go
var ack channeltypes.Acknowledgement
if err := channeltypes.SubModuleCdc.UnmarshalJSON(acknowledgement, &ack); err != nil {
Expand Down
2 changes: 1 addition & 1 deletion docs/architecture/adr-003-ics27-acknowledgement.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ A forwards compatible approach was deemed infeasible.
The `handler` provided by the `MsgServiceRouter` will only include the `*sdk.Result` and an error (if one occurred).
In v0.45 of the SDK, the `*sdk.Result.Data` will contain the MsgResponse marshaled data.
However, the MsgResponse is not packed and marshaled as a `*codectypes.Any`, thus making it impossible from a generalized point of view to unmarshal the bytes.
If the bytes could be unmarshaled, then they could be packed into an `*codectypes.Any` in antcipation of the upcoming format.
If the bytes could be unmarshaled, then they could be packed into an `*codectypes.Any` in anticipation of the upcoming format.

Intercepting the MsgResponse before it becomes marshaled requires replicating this [code](https://github.com/cosmos/cosmos-sdk/blob/dfd47f5b449f558a855da284a9a7eabbfbad435d/baseapp/msg_service_router.go#L109-#L128).
It may not even be possible to replicate the linked code. The method handler would need to be accessed somehow.
Expand Down
2 changes: 0 additions & 2 deletions docs/migrations/v2-to-v3.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ This ensures that the new module's stores are added to the multistore before the
The host and controller submodule keys only need to be added if the chain integrates those submodules.
For example, if a chain chooses not to integrate a controller submodule, it does not need to add the controller key to the `Added` field.


### Genesis migrations

If the chain will adopt ICS27 and chooses to upgrade via a genesis export, then the ICS27 parameters must be set during genesis migration.
Expand Down Expand Up @@ -124,7 +123,6 @@ type AnteDecorator struct {

## IBC Apps


### `OnChanOpenTry` must return negotiated application version

The `OnChanOpenTry` application callback has been modified.
Expand Down
Loading