Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate usage of NewErrorAcknowledgement #1565

Merged
merged 22 commits into from
Jun 28, 2022
Merged

Consolidate usage of NewErrorAcknowledgement #1565

merged 22 commits into from
Jun 28, 2022

Commits on Jun 14, 2022

  1. feat: include ABCI code in failed acknowledgement.

    @chatton
    chatton committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    c264fa0 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. fix: removing transfertypes.NewErrorAcknowledgement and interchainacc… 

    …ounts.NewErrorAcknowledgement in favour of channeltypes.NewErrorAcknowledgement
    @chatton
    chatton committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    1ad5de5 View commit details
    Browse the repository at this point in the history

  2. chore: added PR number to CHANGELOG.md

    @chatton
    chatton committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    e49b35f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into cian/issue#819-add-a-generic-function-to-con… 

    …struct-error-acks-with-abci-codes-&-string-const
    @chatton
    chatton committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    8283fbe View commit details
    Browse the repository at this point in the history

  4. chore: fixed imports

    @chatton
    chatton committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    2fd3b3a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into cian/issue#819-add-a-generic-function-to-con… 

    …struct-error-acks-with-abci-codes-&-string-const
    @chatton
    chatton committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    38c89eb View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Merge branch 'main' into cian/issue#819-add-a-generic-function-to-con… 

    …struct-error-acks-with-abci-codes-&-string-const
    @chatton
    chatton committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    2102783 View commit details
    Browse the repository at this point in the history

  2. chore: addressing PR feedback

    @chatton
    chatton committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    a5d118e View commit details
    Browse the repository at this point in the history

  3. fix: displaying ack error message only if there is an error unmarshal… 

    …ling.
    @chatton
    chatton committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    647d1e1 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into cian/issue#819-add-a-generic-function-to-con… 

    …struct-error-acks-with-abci-codes-&-string-const
    @chatton
    chatton committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    0cd0af3 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. chore: addressed PR feedback

    @chatton
    chatton committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    ea311bd View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. chore: fixing formatting, adding changes to migration doc.

    @chatton
    chatton committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    8e5eb6e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into cian/issue#819-add-a-generic-function-to-con… 

    …struct-error-acks-with-abci-codes-&-string-const
    @chatton
    chatton committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    725ef86 View commit details
    Browse the repository at this point in the history

  3. Update modules/apps/27-interchain-accounts/controller/keeper/events.go 

    Co-authored-by: Damian Nolan <damiannolan@gmail.com>
    @chatton @damiannolan
    chatton and damiannolan committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    52ede1a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into cian/issue#819-add-a-generic-function-to-con… 

    …struct-error-acks-with-abci-codes-&-string-const
    @chatton
    chatton committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    e0a953f View commit details
    Browse the repository at this point in the history

  5. Update docs/migrations/v3-to-v4.md 

    Co-authored-by: Damian Nolan <damiannolan@gmail.com>
    @chatton @damiannolan
    chatton and damiannolan committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    c480718 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into cian/issue#819-add-a-generic-function-to-con… 

    …struct-error-acks-with-abci-codes-&-string-const
    @seantking
    seantking committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    d1089b9 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Merge branch 'main' into cian/issue#819-add-a-generic-function-to-con… 

    …struct-error-acks-with-abci-codes-&-string-const
    @chatton
    chatton committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    230a219 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into cian/issue#819-add-a-generic-function-to-con… 

    …struct-error-acks-with-abci-codes-&-string-const
    @chatton
    chatton committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    6c15291 View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG.md 

    Co-authored-by: Damian Nolan <damiannolan@gmail.com>
    @chatton @damiannolan
    chatton and damiannolan committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    84d2d44 View commit details
    Browse the repository at this point in the history

  4. chore: wrapping errors using sdkerrors.Wrapf

    @chatton
    chatton committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    d3e72ea View commit details
    Browse the repository at this point in the history

  5. chore: fixing imports

    @chatton
    chatton committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    50dfd89 View commit details
    Browse the repository at this point in the history