Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fumpt #1335

Merged
merged 6 commits into from
May 24, 2022
Merged

fumpt #1335

merged 6 commits into from
May 24, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented May 3, 2022

Description

go install mvdan.cc/gofumpt@latest
gofumpt -w -l .

^ really makes the code look great!


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@seantking seantking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me =) No harm in a little spring cleaning!

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Thanks, @faddat!

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, always nice to do some cleanup 🧹 - thanks for doing this!

see comment on read/write access to simd testnet command

testing/simapp/simd/cmd/testnet.go Show resolved Hide resolved
testing/simapp/simd/cmd/testnet.go Show resolved Hide resolved
@faddat
Copy link
Contributor Author

faddat commented May 23, 2022

The write path formatting stuff can be explained here:

golang/go#33363

@faddat faddat requested a review from colin-axner May 23, 2022 15:55
@codecov-commenter
Copy link

Codecov Report

Merging #1335 (083f31d) into main (79ddb9d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1335      +/-   ##
==========================================
- Coverage   80.37%   80.34%   -0.03%     
==========================================
  Files         166      166              
  Lines       12099    12081      -18     
==========================================
- Hits         9724     9707      -17     
+ Misses       1919     1918       -1     
  Partials      456      456              
Impacted Files Coverage Δ
...7-interchain-accounts/controller/keeper/account.go 72.72% <ø> (ø)
...interchain-accounts/controller/keeper/handshake.go 86.44% <ø> (-0.23%) ⬇️
...27-interchain-accounts/controller/keeper/keeper.go 94.73% <ø> (-0.05%) ⬇️
.../27-interchain-accounts/controller/types/params.go 47.82% <ø> (ø)
.../apps/27-interchain-accounts/host/keeper/events.go 0.00% <ø> (ø)
...ps/27-interchain-accounts/host/keeper/handshake.go 84.61% <ø> (-0.30%) ⬇️
.../apps/27-interchain-accounts/host/keeper/keeper.go 83.33% <ø> (-0.17%) ⬇️
...dules/apps/27-interchain-accounts/types/account.go 78.26% <ø> (-0.62%) ⬇️
modules/apps/27-interchain-accounts/types/codec.go 79.54% <ø> (ø)
modules/apps/29-fee/keeper/escrow.go 93.16% <ø> (ø)
... and 22 more

@crodriguezvega crodriguezvega merged commit abd577e into cosmos:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants