Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC support for ibc-transfer/getEscrowAddress #840

Closed
3 tasks
minxylynx opened this issue Feb 2, 2022 · 2 comments · Fixed by #1416
Closed
3 tasks

Add gRPC support for ibc-transfer/getEscrowAddress #840

minxylynx opened this issue Feb 2, 2022 · 2 comments · Fixed by #1416
Assignees
Labels
20-transfer client-UX type: feature New features, sub-features or integrations

Comments

@minxylynx
Copy link

Summary

From this issue #189 came the escrow-address cli function. It would be most useful for end users to have a grpc query route as well.

Problem Definition

As an end-user, I'd like to know what the escrow address is for a particular channel. Using cli isn't feasible when a web app wants to query via gRPC. I have a function that mimics how the escrow address is created, but that won't withstand future changes to the address creation.

Proposal

Add a gRPC route to get the escrow address for a channel, using the same inputs as the CLI.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega added the type: feature New features, sub-features or integrations label Feb 7, 2022
@crodriguezvega crodriguezvega added this to the Q2-2022-backlog milestone Mar 31, 2022
@crodriguezvega
Copy link
Contributor

crodriguezvega commented May 11, 2022

  • Add definition for gRPC escrow-address method in transfers query.proto with route:
rpc EscrowAddress(QueryEscrowAddressRequest) returns (QueryEscrowAddressResponse) {
  option (google.api.http).get = "/ibc/apps/transfer/v1/escrow_address/port/{port_id}/channel/{channel_id}";
}

with request/response messages:

message QueryEscrowAddressRequest {}

message QueryEscrowAddressResponse {
  string escrow_address = 1;
}

@crodriguezvega
Copy link
Contributor

This is now available in v3.1.0, v2.3.0 and v1.5.0.

CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
)

Bumps [go.uber.org/multierr](https://github.com/uber-go/multierr) from
1.10.0 to 1.11.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/uber-go/multierr/releases">go.uber.org/multierr's
releases</a>.</em></p>
<blockquote>
<h2>v1.11.0</h2>
<ul>
<li>Errors now supports any error that implements multiple-error
interface.</li>
<li>Add Every function to allow checking if all errors in the chain
satisfies errors.Is against the target error.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/uber-go/multierr/blob/master/CHANGELOG.md">go.uber.org/multierr's
changelog</a>.</em></p>
<blockquote>
<h1>v1.11.0 (2023-03-28)</h1>
<ul>
<li><code>Errors</code> now supports any error that implements
multiple-error
interface.</li>
<li>Add <code>Every</code> function to allow checking if all errors in
the chain
satisfies <code>errors.Is</code> against the target error.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/uber-go/multierr/commit/de75ae527b39a27afcb50a84427ec7b84021d5f4"><code>de75ae5</code></a>
Release v1.11.0 (<a
href="https://redirect.github.com/uber-go/multierr/issues/79">#79</a>)</li>
<li><a
href="https://github.com/uber-go/multierr/commit/d8067ab0035d5e0ece3cef8cce2c69fd92ce97ad"><code>d8067ab</code></a>
Support multierr.Every (<a
href="https://redirect.github.com/uber-go/multierr/issues/78">#78</a>)</li>
<li><a
href="https://github.com/uber-go/multierr/commit/d42b7a1b108badf09e0227b40dedc2f25848be19"><code>d42b7a1</code></a>
ci: Minimize permissions to workflows (<a
href="https://redirect.github.com/uber-go/multierr/issues/77">#77</a>)</li>
<li><a
href="https://github.com/uber-go/multierr/commit/faff69d9f00cd325d6d0181e7495a70c5f31994f"><code>faff69d</code></a>
Enable Errors support for any multi-error (<a
href="https://redirect.github.com/uber-go/multierr/issues/75">#75</a>)</li>
<li>See full diff in <a
href="https://github.com/uber-go/multierr/compare/v1.10.0...v1.11.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=go.uber.org/multierr&package-manager=go_modules&previous-version=1.10.0&new-version=1.11.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-transfer client-UX type: feature New features, sub-features or integrations
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants