Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update tendermint to v0.35 #539

Closed
2 of 3 tasks
crodriguezvega opened this issue Nov 15, 2021 · 3 comments
Closed
2 of 3 tasks

deps: update tendermint to v0.35 #539

crodriguezvega opened this issue Nov 15, 2021 · 3 comments
Assignees
@crodriguezvega
Labels
dependencies Issues or PRs to update a dependency

Comments

@crodriguezvega
Copy link
Contributor

Summary

Tendermint has released v0.35. I did a quick check and seems like it introduces some code breaking changes in ibc-go. Maybe we can wait for SDK to release a version that also upgrades Tendermint to v0.35 before we upgrade.

Tendermint v0.35 has breaking changes for hermes, so we need to align with them when we do this.

cc: @adizere

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega added the dependencies Issues or PRs to update a dependency label Nov 15, 2021
@adizere
Copy link

adizere commented Nov 15, 2021 •
edited
Loading

Thank you for the heads-up Carlos, appreciate that!

For completeness, on the Hermes side there are (at least) two specific points we want to address wrt upgrading to tm-go 0.35:

@crodriguezvega crodriguezvega modified the milestones: v3.0.0, v1.3.0 Nov 22, 2021
@crodriguezvega crodriguezvega changed the title chore: update tendermint to v0.35 deps: update tendermint to v0.35 Jan 18, 2022
@crodriguezvega crodriguezvega mentioned this issue Jan 18, 2022
Closed
3 tasks
@colin-axner colin-axner mentioned this issue Jan 28, 2022
Closed
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
@alpe
Charge gas for custom event attributes and messages (cosmos#539)
c05df88 
* Charge gas for custom event attributes

* Introduce gas register for gas costs

* Review feedback

* Tests and minor updates

* Godoc
@crodriguezvega crodriguezvega self-assigned this Mar 7, 2022
@colin-axner colin-axner mentioned this issue Mar 8, 2022
Closed
@crodriguezvega crodriguezvega removed this from the v3.a.0 milestone Mar 29, 2022
@crodriguezvega crodriguezvega mentioned this issue Mar 30, 2022
Merged
9 tasks
@crodriguezvega
Copy link
Contributor Author

Since SDK 0.46 will be released with Tendermint 0.34, I am putting this issue on hold for now back in the backlog. We will pick it up again when SDK team plans to release a version with Tendermint 0.35.

@crodriguezvega
Copy link
Contributor Author

Closing this since Tendermint 0.35 has been discontinued.

CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@tzdybal
testing: Use context in integration test (cosmos#539)
3e0fd8d 
Cancellable contexts are use for proper node shutdown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crodriguezvega crodriguezvega

Labels
dependencies Issues or PRs to update a dependency
Projects
ibc-go
Status: Done 🥳
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adizere @crodriguezvega