Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proto builder image in ghcr #2646

Closed
wants to merge 4 commits into from
Closed

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jul 10, 2023

Description

This PR adds a proto builder image Gaia's repository directly that will be
available in ghcr.

Needed to merge #2462


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type
    prefix
    in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR
    Targeting
    )
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@yaruwangway yaruwangway self-assigned this Jul 18, 2023
@yaruwangway
Copy link
Contributor

Hi @mmulji-ic, do we need proto builder image ? btw, where do we hold gaia image ? cc @mpoke

@mpoke mpoke marked this pull request as draft August 22, 2023 14:26
@mpoke
Copy link
Contributor

mpoke commented Aug 22, 2023

Moved to draft as #2462 was moved to draft.

@yaruwangway yaruwangway removed their assignment Oct 2, 2023
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 17, 2023
@github-actions github-actions bot closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants