Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(deps) bump sdk and ibc on top of v10.0.x #2501

Closed
wants to merge 1 commit into from

Conversation

shaspitz
Copy link
Contributor

@shaspitz shaspitz commented May 18, 2023

Description

Credit to @faddat for his work in #2490 which for reasons we don't understand only works on top of gaia::main if you bump comet to v0.24.38, which we cannot do because of cometbft/cometbft#773. Therefore this PR simply bumps sdk and ibc directly ontop of gaia v9.1, which seems to work.

Note: there is no equivalent PR of this one into main, since it did not work!


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API or client breaking change
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@shaspitz shaspitz changed the title deps on 9.1 (deps) bump sdk and ibc on top of v10.0.x May 18, 2023
@shaspitz shaspitz marked this pull request as ready for review May 18, 2023 00:12
@shaspitz shaspitz mentioned this pull request May 18, 2023
18 tasks
MSalopek
MSalopek previously approved these changes May 18, 2023
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Checking the issue with downtime slashing with cometbft 0.34.28 in ICS

EDIT:
This review was redacted as it was incorrect.

@MSalopek MSalopek dismissed their stale review May 18, 2023 10:44

It's not correct after further inspection

Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CometBFT version bump can safely be included.

There's no issues with the CometBFT bump.
A source of non-determinisim was dound in ICS e2e relaying procedure and is addressed by:

@shaspitz shaspitz closed this May 18, 2023
@shaspitz shaspitz deleted the shawn/deps-on-9.1 branch May 18, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants