Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Gov Deposits Querier (Initial Deposit) #8813

Closed
wants to merge 6 commits into from

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Mar 8, 2021

Description

closes: #8758

Deposits querier must include initial deposit by querying submit proposal


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #8813 (145a720) into master (09f9a55) will decrease coverage by 0.07%.
The diff coverage is 21.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8813      +/-   ##
==========================================
- Coverage   59.37%   59.30%   -0.08%     
==========================================
  Files         563      563              
  Lines       31270    31306      +36     
==========================================
- Hits        18566    18565       -1     
- Misses      10546    10583      +37     
  Partials     2158     2158              
Impacted Files Coverage Δ
x/gov/client/utils/query.go 22.55% <0.00%> (-3.18%) ⬇️
store/types/gas.go 79.16% <100.00%> (-15.96%) ⬇️

x/gov/client/utils/query.go Outdated Show resolved Hide resolved
@yun-yeo yun-yeo requested a review from alessio March 11, 2021 03:24
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good and makes sense to me, thanks a lot!

@YunSuk-Yeo Could you add a E2E test? I think we could add a test in the CLI, in x/gov/client/cli/cli_test.go.

}
}

return types.Deposit{}, fmt.Errorf("failed to find the initial deposit for proposalID %d", proposalID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you use sdkerrors.Wrapf here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @YunSuk-Yeo

@clevinson
Copy link
Contributor

@YunSuk-Yeo Any update on tests and fixing merge conflicts here?

@amaury1093
Copy link
Contributor

@YunSuk-Yeo any news? Or else someone on the SDK team could copy the PR and fix the conflicts?

@robert-zaremba
Copy link
Collaborator

With no response, we are forking this branch and adding tests: #9288

@yun-yeo yun-yeo deleted the bugfix/gov-deposits branch January 5, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gov deposits querier not returning all deposits
7 participants