Rename InfoImporter -> LegacyInfoImporter (bp #8739) #8740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Avoid namespace clash with the InfoImporter interface that already exists in the v0.41 release series. (cherry picked from commit 010eeef) # Conflicts: # client/keys/migrate.go # crypto/keyring/keyring.go
mergify
bot
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## release/v0.41.x #8740 +/- ##
===================================================
- Coverage 61.93% 61.44% -0.49%
===================================================
Files 612 673 +61
Lines 35412 38361 +2949
===================================================
+ Hits 21932 23571 +1639
- Misses 11168 12309 +1141
- Partials 2312 2481 +169
|
alessio
approved these changes
Mar 1, 2021
|
This pull request introduces 7 alerts when merging c338c76 into ee90640 - view on LGTM.com new alerts:
|
|
superseded by #8738 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #8739 done by Mergify.
Cherry-pick of 010eeef has failed:
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/