Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codecs: rename MakeCodecs rename and docs update #8245

Merged
merged 6 commits into from
Jan 7, 2021
Merged

codecs: rename MakeCodecs rename and docs update #8245

merged 6 commits into from
Jan 7, 2021

Conversation

robert-zaremba
Copy link
Collaborator

@robert-zaremba robert-zaremba commented Jan 4, 2021 •
edited
Loading

Description

in 9bd42ace6b we renamed and market deprecated the simapp.MakeEncodingConfig function. We forgot about MakeCodecs, which is used only in tests. Also the SDK documentation with regards to MakeCodecs was outdated.

Related to: #7642

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@robert-zaremba robert-zaremba added T:Docs Changes and features related to documentation. Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. C:Encoding labels Jan 4, 2021
amaury1093
amaury1093 reviewed Jan 4, 2021
View reviewed changes
simapp/encoding.go Outdated Show resolved Hide resolved
amaury1093
amaury1093 approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@clevinson
Copy link
Contributor

utACK

@robert-zaremba robert-zaremba added the A:automerge Automatically merge PR once all prerequisites pass. label Jan 7, 2021
@mergify mergify bot merged commit 7fc5e3e into master Jan 7, 2021
@mergify mergify bot deleted the robert/docs-make-codecs branch January 7, 2021 21:50
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@robert-zaremba
codecs: rename MakeCodecs rename and docs update (cosmos#8245)
0b97dee 
* codecs: rename MakeCodecs to MakeTestCodecs

* update changelog

* remove MakeTestCodecs

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clevinson clevinson clevinson approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@blushi blushi Awaiting requested review from blushi

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Encoding T:Docs Changes and features related to documentation. Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robert-zaremba @clevinson @amaury1093