Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate tx commands for auth #7788

Merged
merged 6 commits into from
Nov 4, 2020
Merged

Conversation

sahith-narahari
Copy link
Contributor

Description

This removes auth tx sub commands from simd tx

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #7788 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7788      +/-   ##
==========================================
+ Coverage   54.19%   54.20%   +0.01%     
==========================================
  Files         610      609       -1     
  Lines       38872    38859      -13     
==========================================
  Hits        21065    21065              
+ Misses      15650    15637      -13     
  Partials     2157     2157              

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm 👍 Would like to see a changelog entry

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK'd - pending @amaurymartiny's comments

@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 4, 2020
@mergify mergify bot merged commit 286e9bf into master Nov 4, 2020
@mergify mergify bot deleted the sahith/rm-dup-subcmds branch November 4, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants