Bugfix gov votes querier to use proposal params for proposal query #7589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yun-yeo
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7589 +/- ##
==========================================
+ Coverage 50.58% 54.21% +3.63%
==========================================
Files 451 611 +160
Lines 28389 38464 +10075
==========================================
+ Hits 14361 20854 +6493
- Misses 12575 15502 +2927
- Partials 1453 2108 +655 |
alexanderbez
suggested changes
Oct 19, 2020
x/gov/client/rest/query.go
Outdated
Comment on lines
359
to
363
| bz, err = clientCtx.LegacyAmino.MarshalJSON(params) | ||
| if rest.CheckBadRequestError(w, err) { | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
I would move this block in the else statement as that's the only place we need it.
amaury1093
approved these changes
Oct 20, 2020
anilcse
approved these changes
Oct 20, 2020
alexanderbez
approved these changes
Oct 20, 2020
amaury1093
added
the
A:automerge
yun-yeo
changed the title
9 tasks
alessio
pushed a commit
that referenced
this pull request
Oct 23, 2020
clevinson
pushed a commit
that referenced
this pull request
Oct 29, 2020
* bugfix gov votes querier to use votes params * move partially used statement to the proper block Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The gov proposal querier in votes query interface should use
QueryProposalParamsinstead ofQueryProposalVotesParams.closes: #7588
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes