Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.40.x]: Prepare Changelog & Release Notes for rc0 #7437

Merged
merged 18 commits into from
Oct 7, 2020

Conversation

clevinson
Copy link
Contributor

@clevinson clevinson commented Oct 2, 2020

Description

  • Update changelog
    • Reorganize existing changelog entries
    • Add stargate high level summary
    • Add changelog entries to features / improvements section pertaining to ADR019/020/021
  • add RELEASE_NOTES.md

Rendered Previews:


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@clevinson clevinson marked this pull request as ready for review October 3, 2020 01:26
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release notes are 🔥 !

Just quickly scanned through the changelog, it looks good to me.

RELEASE_NOTES.md Outdated Show resolved Hide resolved
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's good to go

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kick-the-tires-light-the-fires

RELEASE_NOTES.md Outdated
Comment on lines 34 to 35
* [ICS 005 - Port Allocation](https://github.com/cosmos/ics/blob/master/spec/ics-005-port-allocation) subpackage
* [ICS 007 - Tendermint Client](https://github.com/cosmos/ics/blob/master/spec/ics-007-tendermint-client) subpackage
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ICS 006 - Solo Machine Client is missing

CHANGELOG.md Outdated
Comment on lines 256 to 257
* [ICS 005 - Port Allocation](https://github.com/cosmos/ics/blob/master/spec/ics-005-port-allocation) subpackage
* [ICS 007 - Tendermint Client](https://github.com/cosmos/ics/blob/master/spec/ics-007-tendermint-client) subpackage
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

RELEASE_NOTES.md Outdated

## Inter Blockchain Communication (IBC)

The `x/ibc` module is now available and ready for use. For more details check the the [`x/ibc/spec`](https://github.com/cosmos/tree/master/x/ibc/spec) directory:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the spec link is outdated. It should be under x/ibc/core/spec

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be useful to link 3 different things here. The ICS spec, the core code spec and the IBC docs?

clevinson and others added 3 commits October 7, 2020 12:10
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
@clevinson clevinson merged commit 87a7f9c into v0.40.x Oct 7, 2020
@clevinson clevinson deleted the clevinson/0.40-changelog-prep branch October 7, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants