Move codec/std to std #6085
Merged
Move codec/std to std #6085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
aaronc
requested review from
alessio,
alexanderbez,
fedekunze,
hschoenburg and
nylira
as code owners
simapp/cmd/simcli/main.go
Outdated
| @@ -2,6 +2,7 @@ package main | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| "github.com/cosmos/cosmos-sdk/std" | |||
There was a problem hiding this comment.
nit: grouping is incorrect.
There was a problem hiding this comment.
Does make format do this automatically?
| @@ -4,6 +4,7 @@ import ( | |||
| "bufio" | |||
| "errors" | |||
| "fmt" | |||
| "github.com/cosmos/cosmos-sdk/std" | |||
simapp/cmd/simd/main.go
Outdated
| @@ -2,6 +2,7 @@ package main | |||
|
|
|||
| import ( | |||
| "encoding/json" | |||
| "github.com/cosmos/cosmos-sdk/std" | |||
simapp/utils_test.go
Outdated
| @@ -2,18 +2,18 @@ package simapp | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| "github.com/cosmos/cosmos-sdk/std" | |||
x/mint/simulation/decoder_test.go
Outdated
| @@ -2,21 +2,21 @@ package simulation_test | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| "github.com/cosmos/cosmos-sdk/std" | |||
| @@ -2,6 +2,7 @@ package simulation_test | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| "github.com/cosmos/cosmos-sdk/std" | |||
| @@ -1,12 +1,12 @@ | |||
| package staking_test | |||
|
|
|||
| import ( | |||
| "github.com/cosmos/cosmos-sdk/std" | |||
| @@ -1,12 +1,12 @@ | |||
| package keeper_test | |||
|
|
|||
| import ( | |||
| "github.com/cosmos/cosmos-sdk/std" | |||
| @@ -2,6 +2,7 @@ package simulation_test | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| "github.com/cosmos/cosmos-sdk/std" | |||
| @@ -1,11 +1,10 @@ | |||
| package gov_test | |||
|
|
|||
| import ( | |||
| "github.com/cosmos/cosmos-sdk/std" | |||
There was a problem hiding this comment.
[golangci] reported by reviewdog 🐶
File is not goimports-ed (goimports)
…to aaronc/mv-codec-std
alexanderbez
added
R4R
Type: Code Hygiene
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves
codec/stdtostdso that we have just onestdpackage as discussed previously in #6034. It is expected to fail proto break checking as a package was renamed.For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)