Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/keyring: deprecate lazy keybase #5889

Merged
merged 29 commits into from
Mar 30, 2020
Merged

crypto/keyring: deprecate lazy keybase #5889

merged 29 commits into from
Mar 30, 2020

Commits on Mar 29, 2020

  1. Modify New() constructor

    Alessio Treglia committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    be1b8e2 View commit details
    Browse the repository at this point in the history

  2. Remove lazyKeybase

    Alessio Treglia committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    0d6fe88 View commit details
    Browse the repository at this point in the history

  3. Prepare interface

    Alessio Treglia committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    984d5ac View commit details
    Browse the repository at this point in the history

  4. Simplify test

    Alessio Treglia committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    2bf5b20 View commit details
    Browse the repository at this point in the history

  5. keyring.New() -> keyring.NewLegacy()

    Alessio Treglia committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    a27b155 View commit details
    Browse the repository at this point in the history

  6. New in-memory keyring

    Alessio Treglia committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    905b855 View commit details
    Browse the repository at this point in the history

  7. Switch InMemory implementation to new keyring backend

    Alessio Treglia committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    2dad61b View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary dbKeybase code 

    Remove client/keys.NewInMemoryKeyBase alias
    Alessio Treglia committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    16833f8 View commit details
    Browse the repository at this point in the history

  9. Fix race condition

    Alessio Treglia committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    09b8621 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. Add testdata

    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    465712d View commit details
    Browse the repository at this point in the history

  2. set up legacy keybsae test fixtures

    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    fab7e3a View commit details
    Browse the repository at this point in the history

  3. Fix test

    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    171fd18 View commit details
    Browse the repository at this point in the history

  4. Rename db_keybase to legacy. 

    Remove duplicate tests
    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    0bd40e1 View commit details
    Browse the repository at this point in the history

  5. Fix tests

    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    523c8de View commit details
    Browse the repository at this point in the history

  6. Add tests

    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    b04a377 View commit details
    Browse the repository at this point in the history

  7. remove flagDryRun from add command 

    same flag is provided by flags.FlagDryRun
    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    077c22a View commit details
    Browse the repository at this point in the history

  8. Update godoc

    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    c59f8a9 View commit details
    Browse the repository at this point in the history

  9. code cleanup

    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    603232a View commit details
    Browse the repository at this point in the history

  10. legacy keybase does not need to embed baseKeybase

    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    12937d9 View commit details
    Browse the repository at this point in the history

  11. Update CHANGELOG.md

    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    7a761dd View commit details
    Browse the repository at this point in the history

  12. Merge branch 'master' into alessio/remove-old-keybase

    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    9d0b9c5 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'master' into alessio/remove-old-keybase

    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    370b386 View commit details
    Browse the repository at this point in the history

  14. remove keys update command and underlying legacy kb calls

    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    d564b9c View commit details
    Browse the repository at this point in the history

  15. Remove unused function

    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    a8af9b1 View commit details
    Browse the repository at this point in the history

  16. Update client/keys/utils.go 

    Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
    @fedekunze
    Alessio Treglia and fedekunze committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    077ed2f View commit details
    Browse the repository at this point in the history

  17. Update client/keys/utils.go 

    Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
    @fedekunze
    Alessio Treglia and fedekunze committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    2aaa6f9 View commit details
    Browse the repository at this point in the history

  18. Remove the Update method from the Keybase interface

    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    b206bf2 View commit details
    Browse the repository at this point in the history

  19. Update changelog 

    [skip-ci]
    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    30a41ed View commit details
    Browse the repository at this point in the history

  20. bump up coverage

    Alessio Treglia committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    d697766 View commit details
    Browse the repository at this point in the history