Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Empty GasInfo on Failed Msg Validation #5718

Merged
merged 5 commits into from
Feb 28, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 28, 2020

closes: #5713


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez self-assigned this Feb 28, 2020
@alexanderbez alexanderbez changed the title Remove gas call Return Empty GasInfo on Failed Msg Validation Feb 28, 2020
@alexanderbez alexanderbez added R4R and removed WIP labels Feb 28, 2020
@alexanderbez alexanderbez marked this pull request as ready for review February 28, 2020 06:14
@alexanderbez alexanderbez mentioned this pull request Feb 28, 2020
13 tasks
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alexanderbez alexanderbez merged commit 5c1c64b into master Feb 28, 2020
@alexanderbez alexanderbez deleted the bez/5713-fix-baseapp-msg-validate branch February 28, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ValidaterBasic Check in BaseApp
4 participants