IBC SDK Integration #5124

fedekunze · 2019-10-01T15:55:17Z

Replaces: #5057

IMPORTANT: Please do not merge in the downstream PRs until they have been merged and this PR has been rebased to master.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (docs/)
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the github PR explorer

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Bumps [gopkg.in/yaml.v2](https://github.com/go-yaml/yaml) from 2.2.2 to 2.2.3. - [Release notes](https://github.com/go-yaml/yaml/releases) - [Commits](go-yaml/yaml@v2.2.2...v2.2.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

…thub.com/cosmos/cosmos-sdk into fedekunze/ibc-sdk-interface

…s/cosmos-sdk into fedekunze/ibc-sdk-interface

golangcibot · 2019-10-01T16:16:15Z

x/ibc/ante.go

+
+		return ctx, res, false
+	}
+}


File is not goimports-ed (from goimports)

Suggested change

}

}

golangcibot · 2019-10-01T16:16:15Z

x/ibc/keeper.go

+
+func (k Keeper) Port(id string) channel.Port {
+	return k.channel.Port(id)
+}


File is not goimports-ed (from goimports)

Suggested change

}

}

golangcibot · 2019-10-01T16:16:16Z

x/ibc/module.go

+
+func (am AppModule) EndBlock(ctx sdk.Context, req abci.RequestEndBlock) []abci.ValidatorUpdate {
+	return []abci.ValidatorUpdate{}
+}


File is not goimports-ed (from goimports)

Suggested change

}

}

x/ibc/mock/send/keeper.go

codecov · 2019-10-02T00:38:57Z

Codecov Report

Merging #5124 into joon/ics-04-implementation will decrease coverage by 0.07%.
The diff coverage is 13.09%.

@@                      Coverage Diff                       @@
##           joon/ics-04-implementation    #5124      +/-   ##
==============================================================
- Coverage                       55.84%   55.77%   -0.08%     
==============================================================
  Files                             313      314       +1     
  Lines                           18980    19029      +49     
==============================================================
+ Hits                            10600    10613      +13     
- Misses                           7625     7660      +35     
- Partials                          755      756       +1

* Cherry pick from bez/5116-multi-ctx-verifier * fix test

x/ibc/03-connection/client/cli/tx.go

golangcibot · 2019-10-04T17:38:47Z

client/context/context.go

-	chainID := viper.GetString(flags.FlagChainID)
-	home := viper.GetString(flags.FlagHome)
-	nodeURI := viper.GetString(flags.FlagNode)
+// NewCLIContextIBC takes additional arguements


arguements is a misspelling of arguments (from misspell)

Suggested change

// NewCLIContextIBC takes additional arguements

x/ibc/04-channel/client/cli/tx.go

x/ibc/04-channel/manager.go

x/ibc/mock/send/keeper.go

x/ibc/02-client/msgs.go

x/ibc/02-client/client/cli/tx.go

golangcibot · 2019-10-11T01:29:13Z

x/ibc/03-connection/msgs.go

@@ -15,6 +15,16 @@ type MsgOpenInit struct {
 	Signer             sdk.AccAddress `json:"signer"`
 }

+func NewMsgOpenInit(connectionID string, connection Connection, counterpartyClient string, nextTimeout uint64, signer sdk.AccAddress) MsgOpenInit {
+	return MsgOpenInit{
+		ConnectionID: connectionID,


File is not goimports-ed (from goimports)

golangcibot · 2019-10-11T01:29:13Z

x/ibc/02-client/client/cli/tx.go

+				fmt.Fprintf(os.Stderr, "failed to unmarshall input into struct, checking for file...")
+				contents, err := ioutil.ReadFile(args[1])
+				if err != nil {
+					return fmt.Errorf("error opening state file: %v\n", err)


error strings should not be capitalized or end with punctuation or a newline (from golint)

golangcibot · 2019-10-11T01:29:13Z

x/ibc/02-client/client/cli/tx.go

+					return fmt.Errorf("error opening state file: %v\n", err)
+				}
+				if err := cdc.UnmarshalJSON(contents, &state); err != nil {
+					return fmt.Errorf("error unmarshalling state file: %v\n", err)


error strings should not be capitalized or end with punctuation or a newline (from golint)

golangcibot · 2019-10-11T01:29:13Z

x/ibc/02-client/client/cli/tx.go

+				fmt.Fprintf(os.Stderr, "failed to unmarshall input into struct, checking for file...")
+				contents, err := ioutil.ReadFile(args[1])
+				if err != nil {
+					return fmt.Errorf("error opening header file: %v\n", err)


error strings should not be capitalized or end with punctuation or a newline (from golint)

Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>

golangcibot · 2019-10-11T15:35:37Z

x/ibc/02-client/msgs.go

+	return MsgCreateClient{
+		ClientID:       clientID,
+		ConsensusState: consState,
+		Signer: signer,


File is not goimports-ed (from goimports)

Suggested change

Signer: signer,

Signer: signer,

golangcibot · 2019-10-11T15:35:37Z

x/ibc/02-client/client/cli/tx.go

+				fmt.Fprintf(os.Stderr, "failed to unmarshall input into struct, checking for file...")
+				contents, err := ioutil.ReadFile(args[1])
+				if err != nil {
+					return fmt.Errorf("error opening state file: %v\n", err)


error strings should not be capitalized or end with punctuation or a newline (from golint)

golangcibot · 2019-10-11T15:35:37Z

x/ibc/02-client/client/cli/tx.go

+					return fmt.Errorf("error opening state file: %v\n", err)
+				}
+				if err := cdc.UnmarshalJSON(contents, &state); err != nil {
+					return fmt.Errorf("error unmarshalling state file: %v\n", err)


error strings should not be capitalized or end with punctuation or a newline (from golint)

golangcibot · 2019-10-11T15:35:38Z

x/ibc/02-client/client/cli/tx.go

+				fmt.Fprintf(os.Stderr, "failed to unmarshall input into struct, checking for file...")
+				contents, err := ioutil.ReadFile(args[1])
+				if err != nil {
+					return fmt.Errorf("error opening header file: %v\n", err)


error strings should not be capitalized or end with punctuation or a newline (from golint)

golangcibot · 2019-10-11T15:35:46Z

x/ibc/03-connection/types.go

@@ -14,6 +14,14 @@ type Connection struct {
 	Path         commitment.Prefix `json:"path"`
 }

+func NewConnection(client string, counterParty string, path commitment.Prefix) Connection {
+	return Connection{
+		Client: client,


File is not goimports-ed (from goimports)

Suggested change

Client: client,

Client: client,

golangcibot · 2019-10-11T15:35:46Z

x/ibc/03-connection/client/cli/tx.go

+		fmt.Fprintf(os.Stderr, "failed to unmarshall input into struct, checking for file...")
+		contents, err := ioutil.ReadFile(arg)
+		if err != nil {
+			return path, fmt.Errorf("error opening path file: %v\n", err)


error strings should not be capitalized or end with punctuation or a newline (from golint)

golangcibot · 2019-10-11T15:35:47Z

x/ibc/03-connection/client/cli/tx.go

+			return path, fmt.Errorf("error opening path file: %v\n", err)
+		}
+		if err := cdc.UnmarshalJSON(contents, &path); err != nil {
+			return path, fmt.Errorf("error unmarshalling path file: %v\n", err)


error strings should not be capitalized or end with punctuation or a newline (from golint)

golangcibot · 2019-10-11T15:35:47Z

x/ibc/02-client/client/cli/tx.go

@@ -2,22 +2,20 @@ package cli

 import (
 	"io/ioutil"
-	//	"os"
+	"fmt"
+	"io/ioutil"


ioutil redeclared in this block (from typecheck)

…s-sdk into fedekunze/ibc-sdk-interface

cwgoes

There seems to be some duplication between this PR and various ICS PRs.

Either ICS implementations should exist in internal modules and all exports be pulled in at the top level (e.g. message handling, querying) or they should be split up, but here there is duplication, which we should avoid.

My preference would be the former, but it's up to the SDK team.

fedekunze · 2019-11-05T17:25:43Z

replaced by #5277

dependabot-preview bot and others added 4 commits October 1, 2019 13:54

Merge commit 'fea2ba628ccd4a374cf7a33b0a10a5099f19bfc6' of https://gi…

e2a3257

…thub.com/cosmos/cosmos-sdk into fedekunze/ibc-sdk-interface

Merge branch 'joon/ics-04-implementation' of https://github.com/cosmo…

60aa995

…s/cosmos-sdk into fedekunze/ibc-sdk-interface

changes Fede removed by accident on #5057

d53afec

mossid mentioned this pull request Oct 1, 2019

IBC-SDK Integration #5057

Merged

5 tasks

fedekunze changed the title ~~IBC sdk interface~~ IBC SDK Integration Oct 1, 2019

fedekunze added WIP labels Oct 1, 2019

golangcibot reviewed Oct 1, 2019

View reviewed changes

alexanderbez mentioned this pull request Oct 1, 2019

IBC Implementation & Integration #5125

Closed

30 tasks

alexanderbez added this to the IBC Implementation & Integration milestone Oct 1, 2019

Merge PR #5137: IBC Multi-Verifier Cherry Pick

1e45d0b

* Cherry pick from bez/5116-multi-ctx-verifier * fix test

fedekunze added a commit to cosmos/gaia that referenced this pull request Oct 3, 2019

use cosmos/cosmos-sdk#5124 as SDK-IBC interface

edffb9c

Pass in chain-id properly to second cliCtx

7ba0b7e

golangcibot reviewed Oct 4, 2019

View reviewed changes

x/ibc/03-connection/client/cli/tx.go Outdated Show resolved Hide resolved

jackzampolin added 5 commits October 4, 2019 09:31

Attempt to fix panic

5719c35

Explicitly set chain-id before each ctx call

9eaa5d7

Extra logging

902cbae

Change cliCtx initialization

d02becc

Fix build failure for cliCtx intitialization

8b5e7e6

golangcibot reviewed Oct 4, 2019

View reviewed changes

jackzampolin added 4 commits October 7, 2019 10:25

Make sure right txbldr is being used

6e34599

Remove loggin

1c0ae72

Fix clictx generation in connection command

24877f8

Undefined var error in channel command

c620897

golangcibot reviewed Oct 7, 2019

View reviewed changes

x/ibc/04-channel/client/cli/tx.go Show resolved Hide resolved

golangcibot reviewed Oct 7, 2019

View reviewed changes

x/ibc/04-channel/client/cli/tx.go Show resolved Hide resolved

x/ibc/04-channel/client/cli/tx.go Outdated Show resolved Hide resolved

x/ibc/04-channel/client/cli/tx.go Outdated Show resolved Hide resolved

x/ibc/04-channel/client/cli/tx.go Outdated Show resolved Hide resolved

jackzampolin added 2 commits October 7, 2019 10:52

Fix chain-id issue

42b3079

Fix chain-id issue

1addcdf

golangcibot reviewed Oct 7, 2019

View reviewed changes

x/ibc/04-channel/client/cli/tx.go Outdated Show resolved Hide resolved

x/ibc/04-channel/client/cli/tx.go Outdated Show resolved Hide resolved

x/ibc/04-channel/client/cli/tx.go Outdated Show resolved Hide resolved

Demo working until flush

a927a7b

golangcibot reviewed Oct 7, 2019

View reviewed changes

x/ibc/04-channel/client/cli/tx.go Outdated Show resolved Hide resolved

cli send/receive debug in progress

59bfb70

golangcibot reviewed Oct 9, 2019

View reviewed changes

x/ibc/04-channel/manager.go Show resolved Hide resolved

x/ibc/mock/send/keeper.go Show resolved Hide resolved

fix packet sending

b0ad578

fedekunze added the S:blocked Status: Blocked label Oct 10, 2019

Update IBC CLI UX

e690291

golangcibot reviewed Oct 11, 2019

View reviewed changes

jackzampolin and others added 2 commits October 11, 2019 08:32

Update x/ibc/02-client/msgs.go

1a74d7f

Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>

Update x/ibc/02-client/client/cli/tx.go

3d5c97e

Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>

golangcibot reviewed Oct 11, 2019

View reviewed changes

mossid and others added 5 commits October 12, 2019 22:25

utilize ante for packet verification

cf4cc59

Merge branch 'fedekunze/ibc-sdk-interface' of github.com:cosmos/cosmo…

8d74a34

…s-sdk into fedekunze/ibc-sdk-interface

fix typo

11d4258

mv port.name string -> port.key *StoreKey

142a15a

fix next sequence query (#5187)

d5159c6

jackzampolin mentioned this pull request Oct 14, 2019

ICS 04 Implementation #4548

Merged

5 tasks

jackzampolin added 2 commits October 14, 2019 16:27

initialize map in ics-04 Manager type ensuring that demo is working

af28eeb

CLI UX for demo

ee5d7f3

cwgoes suggested changes Oct 15, 2019

View reviewed changes

fedekunze closed this Nov 5, 2019

fedekunze deleted the fedekunze/ibc-sdk-interface branch December 24, 2019 16:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IBC SDK Integration #5124

IBC SDK Integration #5124

fedekunze commented Oct 1, 2019 •

edited

Loading

golangcibot Oct 1, 2019

golangcibot Oct 1, 2019

golangcibot Oct 1, 2019

codecov bot commented Oct 2, 2019 •

edited

Loading

golangcibot Oct 4, 2019

golangcibot Oct 11, 2019

golangcibot Oct 11, 2019

golangcibot Oct 11, 2019

golangcibot Oct 11, 2019

golangcibot Oct 11, 2019

golangcibot Oct 11, 2019

golangcibot Oct 11, 2019

golangcibot Oct 11, 2019

golangcibot Oct 11, 2019

golangcibot Oct 11, 2019

golangcibot Oct 11, 2019

golangcibot Oct 11, 2019

cwgoes left a comment

fedekunze commented Nov 5, 2019

IBC SDK Integration #5124

IBC SDK Integration #5124

Conversation

fedekunze commented Oct 1, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Oct 2, 2019 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cwgoes left a comment

Choose a reason for hiding this comment

fedekunze commented Nov 5, 2019

fedekunze commented Oct 1, 2019 •

edited

Loading

codecov bot commented Oct 2, 2019 •

edited

Loading