Don't reject config files with create_empty_blocks=false #4624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4624 +/- ##
==========================================
+ Coverage 53.62% 53.63% +0.01%
==========================================
Files 260 260
Lines 16177 16177
==========================================
+ Hits 8675 8677 +2
+ Misses 6856 6854 -2
Partials 646 646 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4624 +/- ##
==========================================
+ Coverage 53.62% 53.63% +0.01%
==========================================
Files 260 260
Lines 16177 16177
==========================================
+ Hits 8675 8677 +2
+ Misses 6856 6854 -2
Partials 646 646 |
tac0turtle
approved these changes
Jun 25, 2019
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only valid with #4613 - please merge that first
This reverts #2284 as with #4613 we now support the
create_empty_blocksconfig option. There is no issue, but approval for this PR was given in a review comment: #4613 (comment)As there were no tests for the functionality I removed, I see no need to add a test that this is no longer prohibited.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: