Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: make rest-server respect persistent flags #3453

Merged
merged 2 commits into from
Jan 31, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jan 30, 2019

The rest-server command didn't respect persistent flags such as --chain-id and --trust-node if they were passed on the command line.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio changed the title make rest-server respect persistent flags R4R: make rest-server respect persistent flags Jan 30, 2019
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #3453 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #3453      +/-   ##
===========================================
- Coverage    59.45%   59.43%   -0.03%     
===========================================
  Files          135      135              
  Lines         9981     9981              
===========================================
- Hits          5934     5932       -2     
- Misses        3675     3677       +2     
  Partials       372      372

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good 😎 👍 LGTM

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@cwgoes cwgoes merged commit f4cf45e into develop Jan 31, 2019
@cwgoes cwgoes deleted the alessio/rest-server-dont-respect-chain-id branch January 31, 2019 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants