Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: print out sdk.AccAddress.String() instead of hex #3286

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jan 12, 2019

I've noticed from a terminal log submitted by @faboweb that the gentx command printed out account's address in hex format instead of bech32:

/Users/fabo/Development/voyager/builds/Gaia/darwin_amd64/g
aiad gentx --name main-account --home /Users/fabo/Development
/voyager/builds/testnets/local-testnet/node_home_1 --home-cli
ent /Users/fabo/Development/voyager/builds/testnets/local-tes
tnet/cli_home_1
ERROR: Account 73F007B29DB6F8E794BB10C915612B6FDC32302E is in genesis, but the only has 0stake available to stake, not 100stake

This small PR addresses that. It also lower caps on output strings - errors messages should not begin with capital letters.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio force-pushed the alessio/fix-gentx-error-account-format branch from ef96539 to 377adaf Compare January 12, 2019 14:43
@alessio alessio changed the title print out sdk.AccAddress.String() instead of hex R4R: print out sdk.AccAddress.String() instead of hex Jan 12, 2019
@codecov
Copy link

codecov bot commented Jan 12, 2019

Codecov Report

Merging #3286 into develop will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           develop    #3286   +/-   ##
========================================
  Coverage    55.18%   55.18%           
========================================
  Files          134      134           
  Lines         9526     9526           
========================================
  Hits          5257     5257           
  Misses        3938     3938           
  Partials       331      331

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

PENDING.md Outdated Show resolved Hide resolved
@alessio alessio force-pushed the alessio/fix-gentx-error-account-format branch from 377adaf to 20882f0 Compare January 12, 2019 15:30
@alessio
Copy link
Contributor Author

alessio commented Jan 12, 2019 via email

@faboweb
Copy link
Contributor

faboweb commented Jan 12, 2019

Nice.

@cwgoes cwgoes merged commit e4efb8d into develop Jan 14, 2019
@cwgoes cwgoes deleted the alessio/fix-gentx-error-account-format branch January 14, 2019 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants