Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Sunny/legible tags #3277

Closed
wants to merge 4 commits into from
Closed

WIP: Sunny/legible tags #3277

wants to merge 4 commits into from

Conversation

sunnya97
Copy link
Member

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #3277 into develop will increase coverage by 0.04%.
The diff coverage is 91.89%.

@@             Coverage Diff             @@
##           develop    #3277      +/-   ##
===========================================
+ Coverage    55.33%   55.38%   +0.04%     
===========================================
  Files          135      135              
  Lines         9596     9595       -1     
===========================================
+ Hits          5310     5314       +4     
+ Misses        3954     3949       -5     
  Partials       332      332

@cwgoes
Copy link
Contributor

cwgoes commented Jan 11, 2019

The changes seem reasonable (although not R4R) - can you link to an issue or write a quick spec of the desired result format?

@jackzampolin
Copy link
Member

@cwgoes The idea here is that transaction responses can include plain text (human readable) versions of the tags. Thats not really possible right now.

@alexanderbez
Copy link
Contributor

@sunnya97 bump. What is the status of this?

@jackzampolin
Copy link
Member

Closing in favor of #3451

@cwgoes cwgoes deleted the sunny/legible_tags branch January 31, 2019 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants