Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: write gentx info to cmd.ErrOrStderr #20616

Merged
merged 2 commits into from
Jun 11, 2024
Merged

chore: write gentx info to cmd.ErrOrStderr #20616

merged 2 commits into from
Jun 11, 2024

Conversation

mark-rushakoff
Copy link
Member

@mark-rushakoff mark-rushakoff commented Jun 10, 2024 •
edited by coderabbitai bot
Loading

The "init" and "collect-gentxs" subcommands were hardcoded to write directly to os.Stderr. This made it impossible to write tests against the output. Instead, write to cmd.ErrOrStderr, which will still default to os.Stderr, but will also allow tests to intercept the cobra Command's stderr value in case there is a need to assert against that output.

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling by directing output to the appropriate error stream for better diagnostics in the gentx subcommand.

@mark-rushakoff
chore: write gentx info to cmd.ErrOrStderr
3477c35 
The "init" and "collect-gentxs" subcommands were hardcoded to write
directly to os.Stderr. This made it impossible to write tests against
the output. Instead, write to cmd.ErrOrStderr, which will still default
to os.Stderr, but will also allow tests to intercept the cobra Command's
stderr value in case there is a need to assert against that output.
@mark-rushakoff mark-rushakoff requested a review from a team as a code owner June 10, 2024 18:27
@github-actions github-actions bot added C:CLI C:x/genutil genutil module issues labels Jun 10, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 10, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent changes in the cosmos-sdk involve modifying the output handling of certain commands to use cmd.ErrOrStderr() instead of directly writing to os.Stderr. This enhancement improves flexibility by allowing the output to be redirected as needed. Specifically, the CollectGenTxsCmd and InitCmd functions in the genutil client CLI now pass an io.Writer parameter to the displayInfo function, which uses this parameter for output.

Changes

File Change Summary
x/genutil/client/cli/collect.go Modified CollectGenTxsCmd to pass cmd.ErrOrStderr() to displayInfo.
x/genutil/client/cli/init.go Updated displayInfo to accept an io.Writer parameter and modified InitCmd to pass cmd.ErrOrStderr().
CHANGELOG.md Documented the change in gentx subcommand output handling in pull request #20616.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI
    participant CosmosSDK

    User ->> CLI: Execute CollectGenTxsCmd
    CLI ->> CosmosSDK: CollectGenTxsCmd
    CosmosSDK ->> CLI: Return toPrint
    CLI ->> CLI: Call displayInfo(cmd.ErrOrStderr(), toPrint)
    CLI ->> User: Display Output

    User ->> CLI: Execute InitCmd
    CLI ->> CosmosSDK: InitCmd
    CosmosSDK ->> CLI: Return toPrint
    CLI ->> CLI: Call displayInfo(cmd.ErrOrStderr(), toPrint)
    CLI ->> User: Display Output
Loading

This diagram illustrates the flow for both CollectGenTxsCmd and InitCmd commands, showing how they now use cmd.ErrOrStderr() for output handling.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

tac0turtle
tac0turtle approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Could you add a change log for the api break

coderabbitai[bot]
coderabbitai bot reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7fb2668 and 3477c35.

Files selected for processing (2)
  • x/genutil/client/cli/collect.go (1 hunks)
  • x/genutil/client/cli/init.go (3 hunks)
Additional context used
Path-based instructions (2)
x/genutil/client/cli/collect.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

x/genutil/client/cli/init.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (3)
x/genutil/client/cli/collect.go (1)

55-55: The change to use cmd.ErrOrStderr() enhances testability by allowing stderr redirection. Good improvement!

x/genutil/client/cli/init.go (2)

62-62: Refactoring displayInfo to accept an io.Writer is a solid improvement for flexibility and testability.

Also applies to: 68-68

179-179: Using cmd.ErrOrStderr() in InitCmd aligns with the changes in displayInfo and enhances testability. Ensure to add tests to verify this behavior.

@mark-rushakoff
Copy link
Member Author

Changelog updated in 792b6ac.

coderabbitai[bot]
coderabbitai bot reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3477c35 and 792b6ac.

Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Additional context used
Path-based instructions (1)
CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

Markdownlint
CHANGELOG.md

70-70: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

71-71: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

75-75: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

76-76: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

77-77: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

78-78: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

83-83: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

125-125: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

126-126: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

127-127: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

131-131: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

134-134: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

135-135: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

136-136: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

143-143: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

153-153: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

155-155: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

158-158: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

177-177: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

178-178: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

180-180: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

181-181: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

231-231: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

232-232: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

233-233: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

397-397: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

400-400: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

422-422: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

423-423: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

436-436: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

468-468: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

469-469: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

470-470: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

471-471: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

473-473: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

474-474: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

475-475: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

476-476: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

490-490: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

492-492: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

494-494: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

496-496: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

499-499: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

500-500: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

501-501: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

509-509: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

510-510: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

512-512: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

513-513: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

515-515: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

516-516: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

517-517: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

519-519: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

520-520: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

528-528: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

539-539: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

540-540: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

541-541: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

547-547: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

548-548: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

549-549: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

555-555: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

571-571: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

572-572: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

573-573: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

574-574: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

575-575: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

576-576: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

581-581: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

582-582: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

583-583: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

584-584: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

591-591: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

592-592: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

593-593: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

627-627: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

628-628: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

629-629: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

630-630: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

635-635: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

636-636: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

784-784: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

927-927: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

948-948: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

951-951: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1033-1033: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1034-1034: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1035-1035: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1036-1036: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1037-1037: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1038-1038: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1135-1135: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1221-1221: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1267-1267: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1273-1273: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1274-1274: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1275-1275: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1276-1276: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1277-1277: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1278-1278: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1378-1378: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1503-1503: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1504-1504: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1505-1505: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1506-1506: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1507-1507: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1508-1508: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1509-1509: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1510-1510: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1513-1513: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1514-1514: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1515-1515: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1516-1516: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1517-1517: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1518-1518: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1767-1767: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1768-1768: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1769-1769: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1770-1770: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1771-1771: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1772-1772: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1882-1882: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2219-2219: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2220-2220: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2221-2221: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2224-2224: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2225-2225: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2226-2226: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2248-2248: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2249-2249: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2250-2250: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2251-2251: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2252-2252: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2260-2260: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2261-2261: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2262-2262: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2263-2263: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2264-2264: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2266-2266: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2267-2267: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2268-2268: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2595-2595: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2596-2596: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2597-2597: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2598-2598: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2599-2599: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2601-2601: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2603-2603: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2604-2604: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2605-2605: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2606-2606: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2607-2607: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2608-2608: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2610-2610: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2611-2611: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2612-2612: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2615-2615: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2616-2616: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2617-2617: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2618-2618: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2619-2619: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2622-2622: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2625-2625: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2628-2628: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2629-2629: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2632-2632: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2639-2639: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2640-2640: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2641-2641: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2642-2642: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2643-2643: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2645-2645: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2646-2646: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2647-2647: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2648-2648: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2649-2649: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2650-2650: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2651-2651: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2652-2652: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2653-2653: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2656-2656: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2657-2657: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2658-2658: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2659-2659: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2660-2660: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2661-2661: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2668-2668: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2669-2669: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2670-2670: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2671-2671: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2678-2678: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2680-2680: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2682-2682: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2683-2683: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2684-2684: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2685-2685: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2686-2686: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2687-2687: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2688-2688: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2689-2689: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2690-2690: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2691-2691: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2692-2692: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2693-2693: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2694-2694: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2695-2695: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2696-2696: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2697-2697: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2698-2698: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2699-2699: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2700-2700: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2701-2701: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2702-2702: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2703-2703: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2704-2704: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2705-2705: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2706-2706: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2707-2707: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2708-2708: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2710-2710: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2711-2711: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2713-2713: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2714-2714: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2715-2715: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2716-2716: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2717-2717: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2718-2718: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2719-2719: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2722-2722: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2723-2723: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2725-2725: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2726-2726: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2729-2729: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2730-2730: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2731-2731: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2732-2732: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2733-2733: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2734-2734: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2735-2735: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2736-2736: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2738-2738: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2739-2739: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2740-2740: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2746-2746: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2749-2749: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2755-2755: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2763-2763: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2764-2764: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2765-2765: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2766-2766: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2774-2774: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2781-2781: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2782-2782: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2789-2789: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2791-2791: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2795-2795: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2796-2796: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2798-2798: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2806-2806: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2808-2808: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2809-2809: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2815-2815: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2823-2823: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2824-2824: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2825-2825: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2826-2826: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2827-2827: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2828-2828: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2829-2829: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2830-2830: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2831-2831: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2832-2832: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2833-2833: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2834-2834: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2835-2835: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2836-2836: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2838-2838: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2839-2839: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2841-2841: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2842-2842: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2843-2843: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2844-2844: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2845-2845: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2846-2846: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2847-2847: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2848-2848: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2849-2849: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2850-2850: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2852-2852: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2853-2853: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2856-2856: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2857-2857: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2858-2858: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2859-2859: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2860-2860: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2861-2861: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2862-2862: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2863-2863: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2864-2864: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2865-2865: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2866-2866: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2867-2867: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2868-2868: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2869-2869: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2870-2870: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2871-2871: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2876-2876: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2877-2877: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2878-2878: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2879-2879: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2880-2880: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2881-2881: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2883-2883: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2885-2885: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2899-2899: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2900-2900: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2901-2901: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2906-2906: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2907-2907: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2908-2908: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2912-2912: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2913-2913: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2914-2914: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2915-2915: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2916-2916: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2917-2917: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2920-2920: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2921-2921: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2922-2922: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2923-2923: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2924-2924: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2925-2925: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2926-2926: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2927-2927: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2928-2928: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2930-2930: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2932-2932: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2934-2934: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2939-2939: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2940-2940: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2941-2941: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2942-2942: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2943-2943: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2944-2944: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2945-2945: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2946-2946: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2947-2947: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2948-2948: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2949-2949: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2950-2950: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2951-2951: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2952-2952: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2953-2953: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2954-2954: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2955-2955: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2956-2956: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2957-2957: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2958-2958: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2959-2959: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

187-187: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces

228-228: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces

1137-1137: null (MD024, no-duplicate-heading)
Multiple headings with the same content

1927-1927: null (MD024, no-duplicate-heading)
Multiple headings with the same content

1685-1685: null (MD034, no-bare-urls)
Bare URL used

1715-1715: null (MD034, no-bare-urls)
Bare URL used

2662-2662: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2750-2750: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2752-2752: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2757-2757: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2759-2759: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2769-2769: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2771-2771: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2776-2776: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2784-2784: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2801-2801: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2803-2803: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2811-2811: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2817-2817: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2887-2887: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2890-2890: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2893-2893: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2895-2895: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2935-2935: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

1056-1056: null (MD038, no-space-in-code)
Spaces inside code span elements

2703-2703: null (MD038, no-space-in-code)
Spaces inside code span elements

2703-2703: null (MD038, no-space-in-code)
Spaces inside code span elements

Additional comments not posted (1)
CHANGELOG.md (1)

189-189: Remove trailing spaces to adhere to Markdown best practices.

- * (client) [#20616](https://github.com/cosmos/cosmos-sdk/pull/20616) gentx subcommand output goes to `cmd.ErrOrStderr()` instead of being hardcoded to `os.Stderr`
+ * (client) [#20616](https://github.com/cosmos/cosmos-sdk/pull/20616) gentx subcommand output goes to `cmd.ErrOrStderr()` instead of being hardcoded to `os.Stderr`.

Likely invalid or redundant comment.

@tac0turtle tac0turtle added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 9e1d28e Jun 11, 2024
65 of 67 checks passed
@tac0turtle tac0turtle deleted the mr/gentx-to-cmd-stderr branch June 11, 2024 08:35
alpe added a commit that referenced this pull request Jun 12, 2024
@alpe
Merge branch 'main' into alex/sims_runner
181a8f1 
* main:
  refactor(x/auth): Fix system test (#20531)
  feat(crypto): add blst (#20296)
  docs: Update high level overview and introduction (#20535)
  refactor(x/core): remove test (#20624)
  feat(x/mint)!: Replace InflationCalculationFn with MintFn + simple epoch minting (#20363)
  docs: remove duplicate words (#20622)
  feat: prep for errors v2 (#20539)
  chore: reduce default inflation (#20606)
  refactor(store): add miss defer (#20602)
  chore: use comet api pkg instead of comet alias (#20614)
  chore: write gentx info to cmd.ErrOrStderr (#20616)
  docs: ADR 073: update to accepted and add to README.md (#20619)
  chore(proto): change future extracted modules version from v1.0.0 to v0.2.0 (#20600)
  fix: remove some duplicate words (#20605)
  feat(stf): port simappv2 changes (#20587)
  chore: bring patch changelogs to main (#20599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai coderabbitai left review comments

@tac0turtle tac0turtle tac0turtle approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@testinginprod testinginprod testinginprod approved these changes

Assignees
No one assigned
Labels
C:CLI C:x/genutil genutil module issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mark-rushakoff @tac0turtle @julienrbrt @testinginprod