Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring autocli module config to v0.50 #18111

Merged
merged 11 commits into from
Oct 16, 2023
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Oct 13, 2023

Description

Add relevant autocli config from main.
It will allow Hubl to work nicer with v0.50 chains.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot removed the C:CLI label Oct 16, 2023
@julienrbrt julienrbrt marked this pull request as ready for review October 16, 2023 09:58
@julienrbrt julienrbrt requested a review from a team as a code owner October 16, 2023 09:58
@julienrbrt julienrbrt requested review from atheeshp, a team and likhita-809 and removed request for a team October 16, 2023 09:59
@github-actions
Copy link
Contributor

@julienrbrt your pull request is missing a changelog!

Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, few of the modules missed (for e.g. nft, slashing), aren't they needed to backport?

@julienrbrt
Copy link
Member Author

lgtm, few of the modules missed (for e.g. nft, slashing), aren't they needed to backport?

These are already there, they were backported from the PR already, as they weren't CLI breaking or breaking any tests (see https://github.com/cosmos/cosmos-sdk/blob/release/v0.50.x/x/slashing/autocli.go, or https://github.com/cosmos/cosmos-sdk/blob/release/v0.50.x/x/nft/module/autocli.go)

@julienrbrt julienrbrt merged commit 18733a6 into release/v0.50.x Oct 16, 2023
46 of 50 checks passed
@julienrbrt julienrbrt deleted the julien/autocli-050 branch October 16, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants