Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed key in slashing bitmap migration #18016

Merged
merged 3 commits into from
Oct 10, 2023
Merged

fix: fixed key in slashing bitmap migration #18016

merged 3 commits into from
Oct 10, 2023

Conversation

swelf19
Copy link
Contributor

@swelf19 swelf19 commented Oct 9, 2023

Description

Closes: #18004

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@swelf19 swelf19 requested a review from a team as a code owner October 9, 2023 13:41
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Oct 9, 2023
alexanderbez
alexanderbez approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phenomenal, thank you @swelf19 🙏

@alexanderbez
Copy link
Contributor

@swelf19 can we get a changelog entry please and then we'll merge and backport.

@julienrbrt
Copy link
Member

Hi! Can you run make lint-fix ?

@julienrbrt julienrbrt added this pull request to the merge queue Oct 10, 2023
Merged via the queue into cosmos:main with commit 4001e2b Oct 10, 2023
44 of 46 checks passed
mergify bot pushed a commit that referenced this pull request Oct 10, 2023
@swelf19 @mergify
fix: fixed key in slashing bitmap migration (#18016)
4805c42 
(cherry picked from commit 4001e2b)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Oct 10, 2023
Merged
julienrbrt added a commit that referenced this pull request Oct 10, 2023
@mergify @swelf19 @julienrbrt
fix: fixed key in slashing bitmap migration (backport #18016) (#18033)
8ab33f5 
Co-authored-by: swelf19 <62722506+swelf19@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/slashing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: incorrect missed blocks key during slashing migraion (0.47 -> 0.50)
3 participants
@swelf19 @alexanderbez @julienrbrt