refactor(codec): Modularize Address Codec #17099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tac0turtle we can just merge this into your branch if you'd like |
|
@tac0turtle we can just merge this into your branch if you'd like |
julienrbrt
requested changes
Jul 24, 2023
| @@ -185,9 +184,9 @@ func NewDelegateCmd() *cobra.Command { | |||
| fmt.Sprintf(`Delegate an amount of liquid coins to a validator from your wallet. | |||
|
|
|||
| Example: | |||
| $ %s tx staking delegate %s1l2rsakp388kuv9k8qzq6lrm9taddae7fpx59wm 1000stake --from mykey | |||
| $ %s tx staking delegate cosmoss1l2rsakp388kuv9k8qzq6lrm9taddae7fpx59wm 1000stake --from mykey | |||
There was a problem hiding this comment.
Should be a cosmosvaloper address here.
| @@ -229,9 +226,9 @@ func NewRedelegateCmd() *cobra.Command { | |||
| fmt.Sprintf(`Redelegate an amount of illiquid staking tokens from one validator to another. | |||
|
|
|||
| Example: | |||
| $ %s tx staking redelegate %s1gghjut3ccd8ay0zduzj64hwre2fxs9ldmqhffj %s1l2rsakp388kuv9k8qzq6lrm9taddae7fpx59wm 100stake --from mykey | |||
| $ %s tx staking redelegate cosmoss1gghjut3ccd8ay0zduzj64hwre2fxs9ldmqhffj cosmoss1l2rsakp388kuv9k8qzq6lrm9taddae7fpx59wm 100stake --from mykey | |||
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt
reviewed
Jul 24, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt
reviewed
Jul 24, 2023
| @@ -600,7 +600,7 @@ func (s *E2ETestSuite) TestSimMultiSigTx() { | |||
| val1.Address, | |||
| addr, | |||
| sdk.NewCoins(coins), | |||
| addresscodec.NewBech32Codec("cosmos"), | |||
| addresscodec.NewBech32Codec("cosmosvaloper"), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change