Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(x/distribution): audit changes #16785

Merged
merged 2 commits into from
Jun 30, 2023
Merged

refactor(x/distribution): audit changes #16785

merged 2 commits into from
Jun 30, 2023

Conversation

facundomedica
Copy link
Member

@facundomedica facundomedica commented Jun 30, 2023 •
edited
Loading

Description

Tracking issue #16512

Changes

  • Handle some unhandled errors (both in tests and in main code)
  • Return error in SetPreviousProposerConsAddr
  • Removed GetSigners

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@facundomedica facundomedica mentioned this pull request Jun 30, 2023
Closed
@facundomedica facundomedica added C:x/distribution distribution module related backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release T: Audit R:Eden labels Jun 30, 2023
@facundomedica facundomedica marked this pull request as ready for review June 30, 2023 08:35
@facundomedica facundomedica requested a review from a team as a code owner June 30, 2023 08:36
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 30, 2023
View reviewed changes
x/distribution/abci.go
@@ -23,11 +23,12 @@
// TODO this is Tendermint-dependent
// ref https://github.com/cosmos/cosmos-sdk/issues/3095
if ctx.BlockHeight() > 1 {
k.AllocateTokens(ctx, previousTotalPower, ctx.VoteInfos())
if err := k.AllocateTokens(ctx, previousTotalPower, ctx.VoteInfos()); err != nil {

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
x/distribution/abci.go
}

// record the proposer for when we payout on the next block
consAddr := sdk.ConsAddress(ctx.BlockHeader().ProposerAddress)
k.SetPreviousProposerConsAddr(ctx, consAddr)
return nil
return k.SetPreviousProposerConsAddr(ctx, consAddr)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
julienrbrt
julienrbrt approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@atheeshp atheeshp added this pull request to the merge queue Jun 30, 2023
Merged via the queue into main with commit ec1f0c5 Jun 30, 2023
50 checks passed
@atheeshp atheeshp deleted the facu/distr-audit-v050 branch June 30, 2023 13:14
mergify bot pushed a commit that referenced this pull request Jun 30, 2023
@facundomedica @mergify
refactor(x/distribution): audit changes (#16785)
3eaeaf9 
(cherry picked from commit ec1f0c5)

# Conflicts:
#	tests/integration/distribution/keeper/grpc_query_test.go
#	tests/integration/distribution/keeper/msg_server_test.go
@mergify mergify bot mentioned this pull request Jun 30, 2023
Merged
julienrbrt added a commit that referenced this pull request Jun 30, 2023
@mergify @facundomedica @julienrbrt
refactor(x/distribution): audit changes (backport #16785) (#16799)
950b910 
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@atheeshp atheeshp atheeshp approved these changes

@aaronc aaronc Awaiting requested review from aaronc

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/distribution distribution module related T: Audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@facundomedica @julienrbrt @atheeshp