Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: authz audit changes #16631

Merged
merged 3 commits into from
Jun 22, 2023
Merged

refactor: authz audit changes #16631

merged 3 commits into from
Jun 22, 2023

Conversation

likhita-809
Copy link
Contributor

Description

ref: #16504


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 added backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release and removed C:CLI C:x/authz labels Jun 21, 2023
@likhita-809 likhita-809 marked this pull request as ready for review June 21, 2023 11:39
@likhita-809 likhita-809 requested a review from a team as a code owner June 21, 2023 11:39
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julienrbrt julienrbrt added this pull request to the merge queue Jun 22, 2023
Merged via the queue into main with commit 8d47088 Jun 22, 2023
51 checks passed
@julienrbrt julienrbrt deleted the likhita/authz-audit branch June 22, 2023 06:14
mergify bot pushed a commit that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/authz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants