refactor: cleanup server logic (backport #15041) #16203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we backport this to v0.46.x, we need to re-open #15128 and merge it for v0.47 as well. |
I see, I can fix that PR as well. |
|
recreated a PR for backport to 0.47: #16207 |
alexanderbez
approved these changes
May 18, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+121
to
+130
| go func(enableUnsafeCORS bool) { | ||
| s.logger.Info("starting API server...", "address", cfg.Address) | ||
|
|
||
| s.logger.Info("starting API server...") | ||
| return tmrpcserver.Serve(s.listener, s.Router, s.logger, tmCfg) | ||
| if enableUnsafeCORS { | ||
| allowAllCORS := handlers.CORS(handlers.AllowedHeaders([]string{"Content-Type"})) | ||
| errCh <- tmrpcserver.Serve(s.listener, allowAllCORS(s.Router), s.logger, tmCfg) | ||
| } else { | ||
| errCh <- tmrpcserver.Serve(s.listener, s.Router, s.logger, tmCfg) | ||
| } | ||
| }(cfg.EnableUnsafeCORS) |
Check notice
Code scanning / CodeQL
Spawning a Go routine
julienrbrt
reviewed
May 19, 2023
| ) | ||
|
|
||
| // StartGRPCWeb starts a gRPC-Web server on the given address. | ||
| func StartGRPCWeb(grpcSrv *grpc.Server, config config.Config) (*http.Server, error) { | ||
| func StartGRPCWeb(ctx context.Context, logger log.Logger, grpcSrv *grpc.Server, config config.GRPCWebConfig) error { |
There was a problem hiding this comment.
Are we ok breaking the API in a point release?
| // Note, this creates a blocking process if the server is started successfully. | ||
| // Otherwise, an error is returned. The caller is expected to provide a Context | ||
| // that is properly canceled or closed to indicate the server should be stopped. | ||
| func (s *Server) Start(ctx context.Context, cfg config.APIConfig) error { |
|
please dont break apis in backports unless its needed in backports |
|
Closing because of API break in point version. |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refs: #16202
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change