refactor(simulations): marshal OperationMsg.Msg as protoBytes #16155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:Simulations
C:x/authz
C:x/bank
C:x/distribution
julienrbrt
reviewed
May 15, 2023
types/simulation/types.go
Outdated
| @@ -89,21 +90,18 @@ func NewOperationMsgBasic(moduleName, msgType, comment string, ok bool, msg []by | |||
| } | |||
|
|
|||
| // NewOperationMsg - create a new operation message from sdk.Msg | |||
| func NewOperationMsg(msg sdk.Msg, ok bool, comment string, cdc *codec.ProtoCodec) OperationMsg { | |||
| func NewOperationMsg(msg sdk.Msg, ok bool, comment string, _ *codec.ProtoCodec) OperationMsg { | |||
There was a problem hiding this comment.
I think we should add a changelog entry for chains using this.
…-sdk into kocubinski/sims-protobytes
julienrbrt
reviewed
May 15, 2023
types/simulation/types.go
Outdated
| @@ -89,21 +90,18 @@ func NewOperationMsgBasic(moduleName, msgType, comment string, ok bool, msg []by | |||
| } | |||
|
|
|||
| // NewOperationMsg - create a new operation message from sdk.Msg | |||
| func NewOperationMsg(msg sdk.Msg, ok bool, comment string, cdc *codec.ProtoCodec) OperationMsg { | |||
| func NewOperationMsg(msg sdk.Msg, ok bool, comment string, _ *codec.ProtoCodec) OperationMsg { | |||
There was a problem hiding this comment.
Given that this is anyway a behavior change, why not making it API breaking and remove this argument?
There was a problem hiding this comment.
That makes sense to me.
tac0turtle
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A straightforward refactor to marshal OperationMsg.Msg as proto bytes instead of AminoJSON.
A change was made to this codepath in #16048 migrating to x/tx/aminojson, but working on #16062 I discovered many tests need unmarshal support and unmarshaling is not a planned feature for x/tx/aminjson.
Proto bytes are probably preferable and more performant, I don't really know why we were using AminoJSON in the first place.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change