fix: fetch account number/sequence when not in offline mode #16075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
added
the
backport/v0.47.x
julienrbrt
changed the title
julienrbrt
commented
May 9, 2023
| num, seq, err := fc.accountRetriever.GetAccountNumberSequence(clientCtx, from) | ||
| if err != nil { | ||
| return fc, err | ||
| } | ||
|
|
||
| fc = fc.WithAccountNumber(num) | ||
| fc = fc.WithSequence(seq) | ||
| if initNum == 0 { |
This comment has been minimized.
This comment has been minimized.
julienrbrt
commented
May 9, 2023
| @@ -471,14 +471,19 @@ func (f Factory) Prepare(clientCtx client.Context) (Factory, error) { | |||
| } | |||
There was a problem hiding this comment.
From an offline standpoint, I think, we should not even try the above right?
So, if in offline mode, we simply return the factory early? and keep the ||?
There was a problem hiding this comment.
Alright, doing that then.
alexanderbez
approved these changes
May 9, 2023
|
is there anyway we can add a test case? |
Sure, added. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mergify bot
pushed a commit
that referenced
this pull request
May 10, 2023
(cherry picked from commit bb2d859) # Conflicts: # CHANGELOG.md
kocubinski
pushed a commit
that referenced
this pull request
May 11, 2023
roy-dydx
pushed a commit
to dydxprotocol/cosmos-sdk
that referenced
this pull request
Jul 11, 2023
…osmos#16075) (cosmos#16081) Co-authored-by: Julien Robert <julien@rbrt.fr>
kakysha
pushed a commit
to InjectiveLabs/cosmos-sdk
that referenced
this pull request
Aug 15, 2023
…osmos#16075) (cosmos#16081) Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #15953
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change