feat: ics main changes notional #15944
Conversation
| // a chain must initialize with a non-empty validator set | ||
| if len(validatorUpdates) == 0 { | ||
| return abci.ResponseInitChain{}, fmt.Errorf("validator set is empty after InitGenesis, please ensure at least one validator is initialized with a delegation greater than or equal to the DefaultPowerReduction (%d)", sdk.DefaultPowerReduction) | ||
| } |
There was a problem hiding this comment.
is there any way we can keep this? this is a really good feedback error for me and many others.
There was a problem hiding this comment.
That's what we have been trying to discuss since March 23rd, just there's not been a discussion.
My impression that we probably can, but not without discussing with relevant teams to plan.
I agree with you.
| @@ -476,10 +476,6 @@ func (m *Manager) InitGenesis(ctx sdk.Context, cdc codec.JSONCodec, genesisData | |||
| } | |||
| } | |||
|
|
|||
| // a chain must initialize with a non-empty validator set | |||
There was a problem hiding this comment.
Reposting my comment from here: #15917 (comment)
I am not that familiar with ICS codebase, but this makes sense.
Have you investigated if the consumer app could recover the panic? I know this isn't ideal, but this is a UX improvement for all but consumer chains.
In main, it will be skipping this error, but the question still stands.
| if _, err := k.GetPubkey(ctx, addr); err != nil { | ||
| panic(fmt.Sprintf("Validator consensus-address %s not found", consAddr)) | ||
| } |
There was a problem hiding this comment.
can you touch on why this is being removed
There was a problem hiding this comment.
@vuong177 can. We are getting on a flight right now, so probably tomorrow
|
hey these changes are not needed from my understanding, we talked with the hub team and they said the 0 validator check is not needed since the consumer chain does have validators. Closing this for now |
Description
This PR has changes to GetPubKey that are needed to support ICS.
NOTE
We are still not certain that this is all of the changes that are needed.
We would like to speak with sdk and informal team members to figure out if
there are additional changes needed to the Slash API.
We hope that Informal and SDK teams will please contact Notional about
this matter. Our team has been working on this for quite some time.
We have contacted Informal Systems team members about this matter not less
than four times since March 23, 2023.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change