fix: accaddr cachefix

[KyleMoser]

Description

Closes: #15317

Updates previous PR following advice from @julienrbrt, see #15318 (comment).

Requesting this PR be merged into main, then backported to v0.47 (as this functionality is needed by go relayer).

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[julienrbrt]

Could you add a changelog?

[KyleMoser]

Done, thanks. Missed that in the contributor guide, my bad.

[likhita-809]

lgtm, needs changelog

[julienrbrt]

lgtm!

[julienrbrt]

The changelog should be under the bugfix or improvement section (whichever you think fits best).

[KyleMoser]

Moved it there. Am I finally doing it right? :)

[peterbourgon]

It's unsafe to mutate a global variable like this without synchronization (e.g. a mutex).

[KyleMoser]

It's only meant to be used once on client startup. If I put a mutex in SetAddrCacheEnabled it should also be locked when checking isCachingEnabled, meaning every time an address bech32 conversion happens.

[peterbourgon]

You're correct that both reads and writes need to be synchronized. You might consider atomic.Bool as an alternative.

var cachingEnabled atomic.Bool

func SetCachingEnabled(b bool) { cachingEnabled.Store(b) }
func GetCachingEnabled() bool { return cachingEnabled.Load() }