refactor: remove capability module #15344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
lgtm! we should add section to the UPGRADING.md (### Modules section) and remove it from here: https://github.com/cosmos/cosmos-sdk/tree/main/x#readme
damiannolan
approved these changes
Mar 10, 2023
tac0turtle
added
the
A:automerge
github-actions
bot
added
C:x/crisis
C:x/genutil
julienrbrt
reviewed
Mar 10, 2023
| @@ -252,13 +252,6 @@ const config = { | |||
| ], | |||
| to: "/main/modules/bank", | |||
| }, | |||
| { | |||
| from: [ | |||
There was a problem hiding this comment.
As Marko mentioned, when IBC has a link about capability's readme (after cosmos/ibc-go#3097 is merged). We should redirect these links and /main/modules/capability to the readme (https://github.com/cosmos/ibc-go/blob/marko/capability/capability/README.md but pointing to the main branch then)
19 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
removes capability module since it will ive in ibc-go for 0.48
cosmos/ibc-go#3097
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change