Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: create go.mod for store #14746

Merged
merged 18 commits into from
Jan 25, 2023
Merged

refactor: create go.mod for store #14746

merged 18 commits into from
Jan 25, 2023

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #14668

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 mentioned this pull request Jan 24, 2023
Merged
@likhita-809 likhita-809 marked this pull request as ready for review January 24, 2023 08:01
@likhita-809 likhita-809 requested a review from a team as a code owner January 24, 2023 08:01
julienrbrt
julienrbrt reviewed Jan 24, 2023
View reviewed changes
store/go.mod Outdated Show resolved Hide resolved
simapp/go.mod Outdated Show resolved Hide resolved
store/sonar-project.properties Show resolved Hide resolved
julienrbrt
julienrbrt reviewed Jan 24, 2023
View reviewed changes
store/go.mod Outdated Show resolved Hide resolved
@github-actions github-actions bot added C:CLI C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Rosetta Issues and PR related to Rosetta C:x/auth C:x/authz C:x/bank C:x/capability C:x/consensus C:x/crisis C:x/distribution distribution module related C:x/evidence C:x/feegrant labels Jan 24, 2023
@github-actions github-actions bot removed C:Confix Issues and PR related to Confix C:Rosetta Issues and PR related to Rosetta C:x/tx C:Cosmovisor Issues and PR related to Cosmovisor labels Jan 24, 2023
@likhita-809 likhita-809 mentioned this pull request Jan 24, 2023
Merged
19 tasks
@EmilGeorgiev
Copy link
Contributor

I can't see the README.md file in the directory store. Should it be added in this PR?

@likhita-809
Copy link
Contributor Author

likhita-809 commented Jan 25, 2023 •
edited
Loading

I can't see the README.md file in the directory store. Should it be added in this PR?

not the README.md, but CHANGELOG.md is added here

julienrbrt
julienrbrt approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

store/dbadapter/store_test.go Show resolved Hide resolved
@EmilGeorgiev
Copy link
Contributor

lgtm

tac0turtle
tac0turtle approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow nicely done.

@tac0turtle tac0turtle enabled auto-merge (squash) January 25, 2023 10:11
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Jan 25, 2023
@tac0turtle tac0turtle merged commit 7559d9e into main Jan 25, 2023
@tac0turtle tac0turtle deleted the likhita/store-go-mod branch January 25, 2023 13:31
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@likhita-809 @tac0turtle
refactor: create go.mod for store (cosmos#14746)
7f4e0bc 
Co-authored-by: Marko <marbar3778@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski is a code owner

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:Store C:x/auth C:x/authz C:x/bank C:x/capability C:x/consensus C:x/crisis C:x/distribution distribution module related C:x/evidence C:x/feegrant C:x/genutil genutil module issues C:x/gov C:x/group C:x/mint C:x/nft C:x/params C:x/slashing C:x/staking C:x/upgrade Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

store: create a go.mod for store
4 participants
@likhita-809 @EmilGeorgiev @tac0turtle @julienrbrt