Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Replace testify with gotest.tools in staking integration tests #14504

Merged
merged 20 commits into from
Jan 11, 2023
Merged

chore: Replace testify with gotest.tools in staking integration tests #14504

merged 20 commits into from
Jan 11, 2023

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #14503
ref: #14145 #12332

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 mentioned this pull request Jan 6, 2023
Closed
19 tasks
@likhita-809 likhita-809 marked this pull request as ready for review January 10, 2023 05:37
@likhita-809 likhita-809 requested a review from a team as a code owner January 10, 2023 05:37
julienrbrt
julienrbrt approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! One question.
Thanks for the removal of simapp where it was possible!

tests/integration/staking/keeper/determinstic_test.go Outdated Show resolved Hide resolved
atheeshp
atheeshp reviewed Jan 10, 2023
View reviewed changes
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lgtm

tests/integration/staking/keeper/determinstic_test.go Outdated Show resolved Hide resolved
tests/integration/staking/keeper/determinstic_test.go Outdated Show resolved Hide resolved
atheeshp
atheeshp reviewed Jan 11, 2023
View reviewed changes
tests/integration/staking/keeper/determinstic_test.go
@@ -5,23 +5,17 @@ import (
"time"

"cosmossdk.io/math"
"github.com/stretchr/testify/suite"
"github.com/stretchr/testify/require"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still using require here? Is this intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, require is needed in DeterministicIterations function from testdata package.
We can leave this as of now.
I'll be creating a follow-up PR which removes testify usage testdata package which will eventually end up cleaning testify in tests/integration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I see, there are very less number (mostly 3 to 4) of usages of require in testdata package. Maybe they can be included in this PR. wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already created one: #14575

@likhita-809
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into likh…
baad151 
…ita/replace-testify-staking-integration-tests
atheeshp
atheeshp reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes may resolve failing CI.

tests/integration/staking/keeper/determinstic_test.go Outdated Show resolved Hide resolved
tests/integration/staking/keeper/determinstic_test.go Outdated Show resolved Hide resolved
tests/integration/staking/keeper/determinstic_test.go Outdated Show resolved Hide resolved
@likhita-809
Copy link
Contributor Author

These changes may resolve failing CI.

thanks @atheeshp, these suggestions helped.

@likhita-809 likhita-809 mentioned this pull request Jan 11, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2023

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julienrbrt julienrbrt merged commit f7ead8c into main Jan 11, 2023
@julienrbrt julienrbrt deleted the likhita/replace-testify-staking-integration-tests branch January 11, 2023 13:20
0xmuralik pushed a commit to 0xmuralik/cosmos-sdk that referenced this pull request Jan 12, 2023
@likhita-809 @0xmuralik
chore: Replace testify with gotest.tools in staking integration tests (…
b476810 
…cosmos#14504)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@testinginprod testinginprod Awaiting requested review from testinginprod

@atheeshp atheeshp Awaiting requested review from atheeshp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace testify with gotest.tools in integration/staking tests
5 participants
@likhita-809 @alexanderbez @julienrbrt @atheeshp @facundomedica