Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix --log_format flag not working #14441

Merged
merged 4 commits into from
Dec 29, 2022
Merged

fix: fix --log_format flag not working #14441

merged 4 commits into from
Dec 29, 2022

Conversation

julienrbrt
Copy link
Member

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner December 28, 2022 21:26
@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Dec 28, 2022
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sonarcloud
Copy link

sonarcloud bot commented Dec 29, 2022

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tac0turtle tac0turtle merged commit 82bd888 into main Dec 29, 2022
@tac0turtle tac0turtle deleted the julien/fix-logger branch December 29, 2022 09:09
mergify bot pushed a commit that referenced this pull request Dec 29, 2022
(cherry picked from commit 82bd888)

# Conflicts:
#	CHANGELOG.md
julienrbrt added a commit that referenced this pull request Dec 29, 2022
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Marko <marbar3778@yahoo.com>
@ttl33
Copy link
Contributor

ttl33 commented Dec 29, 2022

Hi Julien! Thanks for adding the fix. Were you able to toggle between json and plain log format after this fix? Asking because when I tested things on our chain, I had to change the default value to json here. Only after this change, I was able to use the input flag to toggle between plain and json.

@julienrbrt
Copy link
Member Author

Hi Julien! Thanks for adding the fix. Were you able to toggle between json and plain log format after this fix? Asking because when I tested things on our chain, I had to change the default value to json here. Only after this change, I was able to use the input flag to toggle between plain and json.

Hi,

Yes I had no problem getting json formatted log with simapp using the flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants