feat(textual): Add Tx envelope Value Renderer #13600
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13600 +/- ##
==========================================
+ Coverage 56.25% 56.88% +0.62%
==========================================
Files 667 647 -20
Lines 56576 55253 -1323
==========================================
- Hits 31829 31431 -398
+ Misses 22165 21255 -910
+ Partials 2582 2567 -15
|
|
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!
|
|
|
||
| // getHash gets the hash of raw bytes to be signed over: | ||
| // HEX(sha256(len(body_bytes) ++ body_bytes ++ len(auth_info_bytes) ++ auth_info_bytes)) | ||
| func getHash(bodyBz, authInfoBz []byte) string { |
There was a problem hiding this comment.
No, you're convinced me.
|
Going to fix the failing test in test-tx first Edit: done |
|
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!
|
…sdk into am/13579-textual-tx
|
[Cosmos SDK - Tx] Kudos, SonarCloud Quality Gate passed!
|
Description
Closes: #13579
For the implementation of this PR, I thought about 3 ways:
fmt.Sprintfs. See beginning of implementation to get an idea.Enveloppeproto message (internal), but we need to also add internal proto annotations to mark expert fields, and modify the MessageValueRenderer (which is already big, as it handles repeated too) to take into account this new expert proto annotation.Part{1..6}proto messages (internal), where odd numbers are not expert, and even numbers are expert, and alternate between value-rendering them.I went with
2b2a in this PR, after #13600 (review)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change