Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove custom marshaling of proposal status #13160

Merged
merged 4 commits into from
Sep 6, 2022

Conversation

tac0turtle
Copy link
Member

Description

Closes: #6787


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle changed the title chore: remove custom marshaling chore: remove custom marshaling of proposal status Sep 6, 2022
@tac0turtle
Copy link
Member Author

does this need a migration @AmauryM

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #13160 (839dd3a) into main (d47970d) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 839dd3a differs from pull request most recent head 9693bbe. Consider uploading reports for the commit 9693bbe to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #13160   +/-   ##
=======================================
  Coverage   53.72%   53.73%           
=======================================
  Files         645      645           
  Lines       55258    55238   -20     
=======================================
- Hits        29688    29682    -6     
+ Misses      23194    23179   -15     
- Partials     2376     2377    +1     
Impacted Files Coverage Δ
x/gov/types/v1/proposal.go 17.24% <ø> (+1.36%) ⬆️
x/gov/types/v1/vote.go 28.91% <ø> (+1.64%) ⬆️
x/gov/types/v1beta1/proposal.go 28.36% <ø> (+0.97%) ⬆️
x/gov/types/v1beta1/vote.go 25.97% <ø> (+1.58%) ⬆️
x/staking/simulation/operations.go 74.54% <0.00%> (-1.38%) ⬇️
x/group/keeper/keeper.go 56.25% <0.00%> (-0.40%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️

@tac0turtle tac0turtle marked this pull request as ready for review September 6, 2022 09:12
@tac0turtle tac0turtle requested a review from a team as a code owner September 6, 2022 09:12
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we need any migration for this

x/gov/types/v1/proposal.go Show resolved Hide resolved
x/gov/types/v1/proposal.go Show resolved Hide resolved
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@tac0turtle tac0turtle enabled auto-merge (squash) September 6, 2022 14:06
@tac0turtle tac0turtle merged commit adf6bf5 into main Sep 6, 2022
@tac0turtle tac0turtle deleted the marko/6787-remove-custom-marshal branch September 6, 2022 14:22
Wryhder pushed a commit to Wryhder/cosmos-sdk that referenced this pull request Oct 26, 2022
* remove custom marshaling

* remove custom marshaling inother places

* add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/gov/types: ProposalStatus.Marshal and ProposalStatus.Unmarshal look suspiciously invalid
3 participants