Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow custom authority and inflation function when using app-wiring #12660

Merged
merged 10 commits into from
Jul 21, 2022
Merged

feat: allow custom authority and inflation function when using app-wiring #12660

merged 10 commits into from
Jul 21, 2022

Conversation

julienrbrt
Copy link
Member

Description

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner July 20, 2022 20:39
@julienrbrt julienrbrt marked this pull request as draft July 20, 2022 20:51
@julienrbrt julienrbrt marked this pull request as ready for review July 20, 2022 21:02
julienrbrt added a commit that referenced this pull request Jul 20, 2022
@julienrbrt
prevent future name clashing and revert app.go changes (in favor of #…
c68734b 
…12660's)
tac0turtle
tac0turtle reviewed Jul 21, 2022
View reviewed changes
x/mint/module.go Outdated
Config *modulev1.Module
Key *store.KVStoreKey
Cdc codec.Codec
Authority types.MintAuthority `optional:"true"`
Copy link
Member

@tac0turtle tac0turtle Jul 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slightly lost where this gets set? I thought you would need to modify protobuf config of each module? (https://github.com/cosmos/cosmos-sdk/blob/main/proto/cosmos/mint/module/v1/module.proto#L13)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We set it in the app.go in depinject.Supply (see comments). This is because it could be just an address or we want to get a module address, so I don't think it can be in the app_config / app.yaml.

Copy link
Member

@tac0turtle tac0turtle Jul 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. still trying to wrap my head around some of DI

alexanderbez
alexanderbez approved these changes Jul 21, 2022
View reviewed changes
x/crisis/types/authority.go Outdated
sdk "github.com/cosmos/cosmos-sdk/types"
)

type CrisisAuthority sdk.AccAddress
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a need for a dedicated type (alias)?

Copy link
Member Author

@julienrbrt julienrbrt Jul 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we named them all Authority, there would be a name collision.

Let me try another implementation to see which one you prefer

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've simplified it in d623377. What do you think?

julienrbrt
julienrbrt commented Jul 21, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@julienrbrt julienrbrt merged commit b72d12e into main Jul 21, 2022
@julienrbrt julienrbrt deleted the julien/app-wiring-func branch July 21, 2022 10:28
This was referenced Jul 21, 2022
Merged
Merged
Closed
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@julienrbrt
feat: allow custom authority and inflation function when using app-wi…
cfbadf1 
…ring (cosmos#12660)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
C:x/bank C:x/crisis C:x/distribution distribution module related C:x/mint C:x/slashing C:x/upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienrbrt @alexanderbez @tac0turtle