feat: Remove x/bank MsgMultiSend

[likhita-809]

Description

Closes: #12397

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Merging #12433 (eee452f) into main (ff3947a) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #12433      +/-   ##
==========================================
- Coverage   65.63%   65.58%   -0.06%     
==========================================
  Files         683      687       +4     
  Lines       71549    71344     -205     
==========================================
- Hits        46959    46788     -171     
+ Misses      21948    21916      -32     
+ Partials     2642     2640       -2     

Impacted Files	Coverage Δ
codec/types/interface_registry.go	53.96% <ø> (ø)
x/bank/client/testutil/cli_helpers.go	50.00% <ø> (-23.69%)	⬇️
x/bank/client/testutil/suite.go	99.36% <ø> (-0.14%)	⬇️
x/bank/keeper/msg_server.go	5.00% <ø> (+1.96%)	⬆️
x/bank/keeper/send.go	84.27% <ø> (+0.52%)	⬆️
x/bank/types/codec.go	100.00% <ø> (ø)
x/bank/types/msgs.go	100.00% <ø> (ø)
x/bank/simulation/operations.go	72.38% <100.00%> (-7.94%)	⬇️
x/group/keeper/keeper.go	58.26% <0.00%> (-0.40%)	⬇️
... and 6 more

[julienrbrt]

Should we not backport this to v0.46? Otherwise we added the multi send cli in v0.46 but we remove it a version later.

If we do that we need to update the changelog.

[julienrbrt]

lgtm but see comment

[likhita-809]

Should we not backport this to v0.46? Otherwise we added the multi send cli in v0.46 but we remove it a version later.

If we do that we need to update the changelog.

If we want this to be added, I can add a changelog
I'm not sure if we should backport this to v0.46
Any comments @alexanderbez ?

[alexanderbez]

I honestly don't have any strong feelings about it. It'll be easier to just leave it in v0.46. Do you think that'll be annoying @julienrbrt?

[julienrbrt]

I honestly don't have any strong feelings about it. It'll be easier to just leave it in v0.46. Do you think that'll be annoying @julienrbrt?

I wouldn't say annoying, but that is weird if a new feature is added in v0.46 and directly dropped the version after.

[alexanderbez]

What's the new feature?

[julienrbrt]

What's the new feature?

#7809 has been implemented in v0.46 rc1. If we were to remove multi-send, then that would have meant adding an extra cli command in v0.46 and removing it altogether in v0.47.

[julienrbrt]

Turns out this feature is being used (#12397 (comment)). We won't remove it from the sdk then.