Bucky/gaiadebug #1232
Merged
Bucky/gaiadebug #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to tm v0.19.6
update tm to 0.17.4
update for tm v0.19.9
Bucky/merge master
Release/v0.18.0
Bucky/testnets
Bucky/testnets
add link to official faucet, remove sequence from cmds readme improvements wording improvements and simplifications add link to cosmos explorer remove instances of candidate add apostrophe small fixes improve the installing software section fixes based on feedback add note about querying an empty account remove panic note update introduction add full cp path for copying genesis.json update moniker warning remove redundant sections add error message when querying empty account don't need a link to golang.org link to sections, better section names fix section link reorganize sections add h3s remove & symbol add whitespace update h3 to h2 add note about explorer not connecting to every node
testnet readme usability overhaul
cwgoes
reviewed
Jun 13, 2018
client/flags.go
Outdated
| @@ -27,6 +27,7 @@ func GetCommands(cmds ...*cobra.Command) []*cobra.Command { | |||
| c.Flags().String(FlagChainID, "", "Chain ID of tendermint node") | |||
| c.Flags().String(FlagNode, "tcp://localhost:46657", "<host>:<port> to tendermint rpc interface for this chain") | |||
| c.Flags().Int64(FlagHeight, 0, "block height to query, omit to get most recent provable block") | |||
| c.Flags().Int64(FlagGas, 200000, "gas limit to set per-transaction") | |||
There was a problem hiding this comment.
This line should be deleted, FlagGas should be in PostCommands - https://github.com/cosmos/cosmos-sdk/pull/1182/files#diff-38b4a4a9824366646939d96f3dc02184R41
Codecov Report
@@ Coverage Diff @@
## develop #1232 +/- ##
===========================================
+ Coverage 66.5% 68.62% +2.12%
===========================================
Files 87 86 -1
Lines 4592 4504 -88
===========================================
+ Hits 3054 3091 +37
+ Misses 1351 1221 -130
- Partials 187 192 +5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gaiadebugcommand