feat: add x/nft app wiring integration tests #12220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronc
approved these changes
Jun 10, 2022
x/nft/client/testutil/cli_test.go
Outdated
| func TestIntegrationTestSuite(t *testing.T) { | ||
| cfg := network.DefaultConfig() | ||
| cfg, err := network.DefaultConfigWithAppConfig(appconfig.LoadYAML(appConfig)) |
There was a problem hiding this comment.
We should put the app config after it's been loaded in a var that can be used by other tests in this module that need app config. Probably in an internal testutil package
There was a problem hiding this comment.
👍🏾 added in x/nft/testutil
Codecov Report
@@ Coverage Diff @@
## main #12220 +/- ##
==========================================
- Coverage 66.16% 66.13% -0.03%
==========================================
Files 672 672
Lines 70955 70981 +26
==========================================
Hits 46944 46944
- Misses 21376 21402 +26
Partials 2635 2635
|
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* feat: add x/nft app wiring integration tests * updates * feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements part of: #12038
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change