feat: add Coins.Find method #11959
Merged
feat: add Coins.Find method #11959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
added
C:Types
backport/0.46.x
Codecov Report
@@ Coverage Diff @@
## main #11959 +/- ##
==========================================
+ Coverage 65.94% 65.96% +0.02%
==========================================
Files 677 677
Lines 71332 71336 +4
==========================================
+ Hits 47039 47060 +21
+ Misses 21609 21591 -18
- Partials 2684 2685 +1
|
robert-zaremba
requested review from
aleem1314,
alexanderbez,
amaury1093,
anilcse,
atheeshp and
tac0turtle
robert-zaremba
added
the
A:automerge
types/coin.go
Outdated
| } | ||
| return ZeroInt() | ||
| return false, Coin{"", ZeroInt()} |
There was a problem hiding this comment.
Why not just the empty Coin{} literal? The caller knows based of the bool that it's found or not.
There was a problem hiding this comment.
Coin{} has a nil amount. ok=false is not an error.
There was a problem hiding this comment.
I'm not following. You'd never use the coin if ok=false, so I don't think it matters if coin actually contains and we shouldn't allocate a ZeroInt() when we don't have to IMO
There was a problem hiding this comment.
AmountOfNoDenomValidation and AmountOf uses it.
I agree, that it creates an allocation which is not always needed. If you really think it's better to avoid that allocation, then I will update. lmk
There was a problem hiding this comment.
Yeah, I'd rather just return Coin{} IMO
There was a problem hiding this comment.
OK, updated
mergify bot
pushed a commit
that referenced
this pull request
May 18, 2022
Added a new helper method to find a coin in a set of `sdk.Coins` by denom. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 23baecf) # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new helper method to find a coin in a set of
sdk.Coinsby denom.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change