Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(errors): test failures #10879

Merged
merged 2 commits into from
Jan 4, 2022
Merged

fix(errors): test failures #10879

merged 2 commits into from
Jan 4, 2022

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jan 4, 2022

Description

Fixes some test failures in errors that I'm almost certain didn't show up in #10779. Seems like all tests weren't running properly there.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc marked this pull request as ready for review January 4, 2022 22:53
@aaronc aaronc requested a review from tac0turtle January 4, 2022 22:53
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #10879 (d62fb5c) into master (344be86) will increase coverage by 0.05%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10879      +/-   ##
==========================================
+ Coverage   64.63%   64.69%   +0.05%     
==========================================
  Files         620      614       -6     
  Lines       59424    58984     -440     
==========================================
- Hits        38409    38157     -252     
+ Misses      18852    18685     -167     
+ Partials     2163     2142      -21     
Impacted Files Coverage Δ
x/gov/types/v1beta2/codec.go 42.10% <ø> (ø)
x/gov/types/v1beta2/deposit.go 0.00% <ø> (ø)
x/gov/types/v1beta2/genesis.go 47.50% <ø> (ø)
x/gov/types/v1beta2/params.go 22.22% <ø> (ø)
x/gov/types/v1beta2/proposal.go 16.12% <ø> (ø)
x/gov/types/v1beta2/tally.go 0.00% <ø> (ø)
x/gov/types/v1beta2/vote.go 29.26% <ø> (ø)
x/gov/types/v1beta2/msgs.go 49.28% <71.42%> (ø)
x/gov/keeper/querier.go 38.75% <75.00%> (ø)
errors/stacktrace.go 84.14% <100.00%> (ø)
... and 18 more

@aaronc aaronc merged commit 401cf2f into master Jan 4, 2022
@aaronc aaronc deleted the aaronc/errors-test-fixes branch January 4, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants