Standarize REST errors response msgs

[fedekunze]

Summary

Create a standard value for error messages in REST responses

Problem Definition

Even thought the new object format makes it easier to get each of the components of an error (eg: codespace, code, abci_code, and message) Currently clients have to parse the content of the message value to get the desired format. For example:

{"codespace":1,"code":12,"abci_code":65548,"message":"checkTx failed: Error{out of gas in location: WritePerByte}"}

This is caused by a series of added messages to the error, such as fmt.Sprintf("checkTx failed: %s", err.Error())

Ref to voyager issue for parsing Errors: luniehq/lunie#1131
Ref to user feedback issue about the same problem: #1892

Proposal

• refactor to use utils.WriteErrorResponse(w http.ResponseWriter, status int, msg string) as the desired format for errors
• additional msgs should go inside the error msg: eg: "message":"Error{checkTx failed; out of gas in location: WritePerByte}"

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[jackzampolin]

This is a great proposal! Lets adopt!

[fedekunze]

here's another example of the message value:

deliverTx failed: (262246) Msg 0 failed: Error{no unbonding delegation found}